This is an archive of the discontinued LLVM Phabricator instance.

Differential D8175

[Sanitizers] Fix sanitizers to build on FreeBSD.
ClosedPublic

Authored by kutuzov.viktor.84 on Mar 9 2015, 9:52 AM.

Details

Reviewers
kcc
emaste
dvyukov
samsonov
Commits
rCRT232072: [Sanitizers] Fix sanitizers to build on FreeBSD.
rL232072: [Sanitizers] Fix sanitizers to build on FreeBSD.
Summary

This patch completes the changes made in D8005 / rL230978.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 updated this revision to Diff 21496.Mar 9 2015, 9:52 AM
kutuzov.viktor.84 retitled this revision from to [Sanitizers] Fix sanitizers to build on FreeBSD..
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov, dvyukov, emaste.
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Mar 9 2015, 11:02 AM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 9 2015, 11:02 AM
dvyukov added inline comments.Mar 10 2015, 12:45 AM
lib/sanitizer_common/sanitizer_linux.cc
63 ↗(On Diff #21496)

Shouldn't it be included on linux as well?
I guess it is included by some other header on linux, but it is not a reason to not include it explicitly if we use it.

kutuzov.viktor.84 updated this revision to Diff 21813.Mar 12 2015, 3:55 AM
kutuzov.viktor.84 edited edge metadata.

Updated.

dvyukov accepted this revision.Mar 12 2015, 4:10 AM
dvyukov edited edge metadata.

LGTM

Closed by commit rL232072: [Sanitizers] Fix sanitizers to build on FreeBSD. (authored by vkutuzov). · Explain WhyMar 12 2015, 11:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
1 line

Diff 21854

compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
#include <sched.h> #include <sched.h>
#include <sys/mman.h> #include <sys/mman.h>
#include <sys/ptrace.h> #include <sys/ptrace.h>
#include <sys/resource.h> #include <sys/resource.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/syscall.h> #include <sys/syscall.h>
#include <sys/time.h> #include <sys/time.h>
#include <sys/types.h> #include <sys/types.h>
#include <ucontext.h>
#include <unistd.h> #include <unistd.h>
#if SANITIZER_FREEBSD #if SANITIZER_FREEBSD
#include <sys/sysctl.h> #include <sys/sysctl.h>
#include <machine/atomic.h> #include <machine/atomic.h>
extern "C" { extern "C" {
// <sys/umtx.h> must be included after <errno.h> and <sys/types.h> on // <sys/umtx.h> must be included after <errno.h> and <sys/types.h> on
// FreeBSD 9.2 and 10.0. // FreeBSD 9.2 and 10.0.
▲ Show 20 Lines • Show All 940 Lines • Show Last 20 Lines