Page MenuHomePhabricator

kutuzov.viktor.84 (Viktor Kutuzov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2013, 11:09 AM (294 w, 3 d)

Recent Activity

Feb 1 2019

kutuzov.viktor.84 added a reverting change for D3908: Add clang headers that fix machine-dependent definitions on FreeBSD 9.2: rG99400a5a34df: Revert D3908 due to issues on Mac platforms.
Feb 1 2019, 11:15 AM

May 11 2015

kutuzov.viktor.84 updated the diff for D9553: [Msan] Make the pthread_getattr_np_deadlock.cc test Linux-specific.

Updated.

May 11 2015, 7:56 AM

May 8 2015

kutuzov.viktor.84 updated the diff for D9456: [Msan] Fix the if_indextoname.cc test to pass on FreeBSD.

Updated.

May 8 2015, 5:08 AM
kutuzov.viktor.84 added a comment to D9456: [Msan] Fix the if_indextoname.cc test to pass on FreeBSD.

Maybe change the if_indextoname interceptor to poison this area?

May 8 2015, 5:08 AM
kutuzov.viktor.84 added inline comments to D9553: [Msan] Make the pthread_getattr_np_deadlock.cc test Linux-specific.
May 8 2015, 4:47 AM

May 7 2015

kutuzov.viktor.84 retitled D9554: [Msan] Fix the report-demangling.cc test to pass on FreeBSD from to [Msan] Fix the report-demangling.cc test to pass on FreeBSD.
May 7 2015, 5:25 AM
kutuzov.viktor.84 retitled D9553: [Msan] Make the pthread_getattr_np_deadlock.cc test Linux-specific from to [Msan] Fix the pthread_getattr_np_deadlock.cc to build and pass on FreeBSD.
May 7 2015, 5:23 AM
kutuzov.viktor.84 retitled D9552: [Msan] Make the obstack.cc test Linux-specific from to [Msan] Make the obstack.cc test Linux-specific.
May 7 2015, 5:21 AM
kutuzov.viktor.84 added a comment to D9460: [Msan] Make the ioctl_sound.cc test Linux-specific.

It's already there so we just move it under Linux/.

May 7 2015, 5:03 AM

May 6 2015

kutuzov.viktor.84 updated the diff for D9461: [Msan] Make the mallinfo.cc test Linux-specific.

Updated.

May 6 2015, 3:56 AM
kutuzov.viktor.84 updated the diff for D9460: [Msan] Make the ioctl_sound.cc test Linux-specific.

Updated.

May 6 2015, 3:55 AM

May 2 2015

kutuzov.viktor.84 retitled D9462: [Msan] Fix the mmap_below_shadow.cc test to pass on FreeBSD from to [Msan] Fix the mmap_below_shadow.cc test to pass on FreeBSD.
May 2 2015, 9:03 AM
kutuzov.viktor.84 retitled D9461: [Msan] Make the mallinfo.cc test Linux-specific from to [Msan] XFAIL the mallinfo.cc test on FreeBSD.
May 2 2015, 9:02 AM
kutuzov.viktor.84 retitled D9460: [Msan] Make the ioctl_sound.cc test Linux-specific from to [Msan] XFAIL the ioctl_sound.cc test on FreeBSD.
May 2 2015, 9:00 AM
kutuzov.viktor.84 retitled D9459: [Msan] Fix the ioctl_custom.cc test to pass on FreeBSD from to [Msan] Fix the ioctl_custom.cc test to pass on FreeBSD.
May 2 2015, 8:59 AM
kutuzov.viktor.84 retitled D9458: [Msan] Fix the initgroups.cc test to build on FreeBSD from to [Msan] Fix the initgroups.cc test to build on FreeBSD.
May 2 2015, 8:58 AM
kutuzov.viktor.84 retitled D9457: [Msan] Fix the ifaddrs.cc test to build and pass on FreeBSD from to [Msan] Fix the ifaddrs.cc test to build and pass on FreeBSD.
May 2 2015, 8:56 AM
kutuzov.viktor.84 retitled D9456: [Msan] Fix the if_indextoname.cc test to pass on FreeBSD from to [Msan] Fix the if_indextoname.cc test to pass on FreeBSD.
May 2 2015, 8:55 AM

Apr 28 2015

kutuzov.viktor.84 added a comment to rL235759: libc++abi: remove the duplicated unwind content.

(CC your mail box)

Apr 28 2015, 3:20 AM

Apr 27 2015

kutuzov.viktor.84 added a comment to D9251: [Msan] Fix the getline.cc test to pass on FreeBSD.

Thanks Eugeniy. The plan is to disable non-FreeBSD interceptors with another series of commits, unless there's some urgency about it.

Apr 27 2015, 11:24 AM

Apr 25 2015

kutuzov.viktor.84 added a comment to D9251: [Msan] Fix the getline.cc test to pass on FreeBSD.

Why do you need this change in getdelim interceptors?

Apr 25 2015, 7:59 AM
kutuzov.viktor.84 updated the diff for D9251: [Msan] Fix the getline.cc test to pass on FreeBSD.

Updated to eliminate the ellipsis parameter.

Apr 25 2015, 7:53 AM
kutuzov.viktor.84 retitled D9272: Fix libunwind to build on FreeBSD from to Fix libunwind to build on FreeBSD.
Apr 25 2015, 7:09 AM

Apr 24 2015

kutuzov.viktor.84 retitled D9252: [Msan] Fix the iconv.cc test to build and pass on FreeBSD from to [Msan] Fix the iconv.cc test to build and pass on FreeBSD.
Apr 24 2015, 5:38 AM
kutuzov.viktor.84 retitled D9251: [Msan] Fix the getline.cc test to pass on FreeBSD from to [Msan] Fix the getline.cc test to pass on FreeBSD.
Apr 24 2015, 5:37 AM

Apr 23 2015

kutuzov.viktor.84 retitled D9222: [Msan] XFAIL the ftime.cc test on FreeBSD from to [Msan] XFAIL the ftime.cc test on FreeBSD.
Apr 23 2015, 6:44 AM
kutuzov.viktor.84 retitled D9221: [Msan] Fix the backtrace.cc tests to build and pass on FreeBSD from to [Msan] Fix the backtrace.cc tests to build and pass on FreeBSD.
Apr 23 2015, 6:39 AM
kutuzov.viktor.84 retitled D9220: [Sanitizers] Do not call internal_sigdelset() on non-Linux from to [Sanitizers] Do not call internal_sigdelset() on non-Linux.
Apr 23 2015, 6:37 AM

Apr 5 2015

kutuzov.viktor.84 edited reviewers for D8834: [Asan] Link lit tests shared libraries with -Wl,z,origin on FreeBSD, added: samsonov; removed: sam.saariste.
Apr 5 2015, 2:48 AM
kutuzov.viktor.84 retitled D8834: [Asan] Link lit tests shared libraries with -Wl,z,origin on FreeBSD from to [Asan] Link lit tests shared libraries with -Wl,z,origin on FreeBSD.
Apr 5 2015, 2:47 AM

Mar 26 2015

kutuzov.viktor.84 added a comment to D8543: [Tsan] Do not sanitize memset() and other functions during initialization.

Updated in D8544.

Mar 26 2015, 2:33 AM
kutuzov.viktor.84 updated the diff for D8544: [Tsan] Do not sanitize memset() and other functions during initialization.

Updated as suggested in D8543#inline-69954.

Mar 26 2015, 2:30 AM

Mar 23 2015

kutuzov.viktor.84 updated D8551: [Sanitizers] Fix internal_ftruncate() to work on FreeBSD.
Mar 23 2015, 9:00 AM
kutuzov.viktor.84 retitled D8551: [Sanitizers] Fix internal_ftruncate() to work on FreeBSD from to [Sanitizers] Fix internal_ftruncate() to work on FreeBSD.
Mar 23 2015, 9:00 AM
kutuzov.viktor.84 retitled D8545: [Tsan] Fix the mmap_large.cc test to build on FreeBSD from to [Tsan] Fix the mmap_large.cc test to build on FreeBSD.
Mar 23 2015, 7:32 AM
kutuzov.viktor.84 abandoned D8543: [Tsan] Do not sanitize memset() and other functions during initialization.
Mar 23 2015, 7:28 AM
kutuzov.viktor.84 retitled D8544: [Tsan] Do not sanitize memset() and other functions during initialization from to [Tsan] Do not sanitize memset() and other functions during initialization.
Mar 23 2015, 7:27 AM
kutuzov.viktor.84 updated subscribers of D8543: [Tsan] Do not sanitize memset() and other functions during initialization.
Mar 23 2015, 7:22 AM
kutuzov.viktor.84 retitled D8543: [Tsan] Do not sanitize memset() and other functions during initialization from to [Tsan] Do not sanitize memset() and other functions during initialization.
Mar 23 2015, 7:21 AM

Mar 16 2015

kutuzov.viktor.84 updated the diff for D8324: [Tsan] Do not sanitize memcpy() during thread initialization on FreeBSD.

Updated.

Mar 16 2015, 7:31 AM

Mar 13 2015

kutuzov.viktor.84 retitled D8324: [Tsan] Do not sanitize memcpy() during thread initialization on FreeBSD from to [Tsan] Do not sanitize memcpy() during thread initialization on FreeBSD.
Mar 13 2015, 11:12 AM

Mar 12 2015

kutuzov.viktor.84 retitled D8303: [Tsan] Fix test.h to work on FreeBSD from to [Tsan] Fix test.h to work on FreeBSD.
Mar 12 2015, 12:02 PM
kutuzov.viktor.84 retitled D8288: [Tsan] Do not declare std_suppressions when not used from to [Tsan] Do not declare std_suppressions when not used.
Mar 12 2015, 6:03 AM
kutuzov.viktor.84 updated the diff for D8175: [Sanitizers] Fix sanitizers to build on FreeBSD..

Updated.

Mar 12 2015, 3:55 AM

Mar 9 2015

kutuzov.viktor.84 retitled D8176: [Tsan] Adjust SA_SIGINFO and SIG_SETMASK values on FreeBSD. from to [Tsan] Adjust SA_SIGINFO and SIG_SETMASK values on FreeBSD..
Mar 9 2015, 10:01 AM
kutuzov.viktor.84 retitled D8175: [Sanitizers] Fix sanitizers to build on FreeBSD. from to [Sanitizers] Fix sanitizers to build on FreeBSD..
Mar 9 2015, 9:52 AM

Feb 16 2015

kutuzov.viktor.84 updated the diff for D7587: [Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD.

Updated.

Feb 16 2015, 11:16 AM

Feb 12 2015

kutuzov.viktor.84 retitled D7588: [Msan] Make unit tests that use mempcpy() passing on FreeBSD from to [Msan] Make unit tests that use mempcpy() passing on FreeBSD.
Feb 12 2015, 6:00 AM
kutuzov.viktor.84 added inline comments to D7587: [Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD.
Feb 12 2015, 5:54 AM
kutuzov.viktor.84 retitled D7587: [Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD from to [Msan] Fix the unit tests' PathToLoadable() to work on FreeBSD.
Feb 12 2015, 5:51 AM
kutuzov.viktor.84 retitled D7586: [Asan] Fix the dlclose-test.cc unit test to build on FreeBSD 11 from to [Asan] Fix the dlclose-test.cc unit test to build on FreeBSD 11.
Feb 12 2015, 5:44 AM

Feb 11 2015

kutuzov.viktor.84 added a comment to D7485: Define MAP_NORESERVE to zero for FreeBSD.

Looks OK to me.

Feb 11 2015, 7:25 AM

Feb 8 2015

kutuzov.viktor.84 added a reviewer for D7486: Remove inclusion of ip_compat.h for FreeBSD: samsonov.
Feb 8 2015, 3:56 AM
kutuzov.viktor.84 added a reviewer for D7485: Define MAP_NORESERVE to zero for FreeBSD: samsonov.
Feb 8 2015, 3:55 AM

Feb 2 2015

kutuzov.viktor.84 retitled D7343: [Msan] Disable the fgetgrent_r unit test on FreeBSD from to [Msan] Disable the fgetgrent_r unit test on FreeBSD.
Feb 2 2015, 5:37 AM
kutuzov.viktor.84 retitled D7342: [Msan] Fix the pthread_attr_get unit test to build on FreeBSD from to [Msan] Fix the pthread_attr_get unit test to build on FreeBSD.
Feb 2 2015, 5:34 AM
kutuzov.viktor.84 retitled D7341: [Msan] Improve the EXPECT_NOT_POISONED() macro to provide the original line number from to [Msan] Improve the EXPECT_NOT_POISONED() macro to provide the original line number.
Feb 2 2015, 5:30 AM
kutuzov.viktor.84 retitled D7340: [Msan] Disable fcvt unit tests on FreeBSD from to [Msan] Disable fcvt unit tests on FreeBSD.
Feb 2 2015, 5:24 AM
kutuzov.viktor.84 retitled D7339: [Msan] Fix the getgrnam_r unit test to pass on FreeBSD from to [Msan] Fix the getgrnam_r unit test to pass on FreeBSD.
Feb 2 2015, 5:22 AM
kutuzov.viktor.84 retitled D7335: [Msan] Fix the sigaction unit test to build on FreeBSD from to [Msan] Fix the sigaction unit test to build on FreeBSD.
Feb 2 2015, 2:09 AM
kutuzov.viktor.84 retitled D7334: [Msan] Fix the ether unit test to build on FreeBSD from to [Msan] Fix the ether unit test to build on FreeBSD.
Feb 2 2015, 2:08 AM
kutuzov.viktor.84 added a comment to D6892: [Sanitizers] Order initialization of coverage and guard arrays.

Re-applied as rL227789.

Feb 2 2015, 1:41 AM

Jan 30 2015

kutuzov.viktor.84 added a comment to D6892: [Sanitizers] Order initialization of coverage and guard arrays.

OK, it seems to be a design-level issue and needs some investigation. The question is: can we re-apply rL226440 for now to make things working with the existing UBsan tests on FreeBSD? Or, would you like me to prepare a patch introducing the ENSURE_UBSAN_INITED() kind of things? Thanks.

Jan 30 2015, 4:15 AM

Jan 29 2015

kutuzov.viktor.84 retitled D7253: [Msan] Fix the shmctl unit tests to pass on FreeBSD from to [Msan] Fix the shmctl unit tests to pass on FreeBSD.
Jan 29 2015, 7:43 AM
kutuzov.viktor.84 retitled D7252: [Msan] Disable unit tests for non-FreeBSD functions on FreeBSD from to [Msan] Disable unit tests for non-FreeBSD functions on FreeBSD.
Jan 29 2015, 7:41 AM
kutuzov.viktor.84 added a comment to D7233: [Sanitizers] Introduce GET_LINK_MAP_BY_DLOPEN_HANDLE() macro.

Is it possible to calculate it in sanitizer_platform_limits_posix.cc by using offsetof() ?

Jan 29 2015, 3:29 AM
kutuzov.viktor.84 updated the diff for D7233: [Sanitizers] Introduce GET_LINK_MAP_BY_DLOPEN_HANDLE() macro.

Reworked. Thanks.

Jan 29 2015, 3:24 AM

Jan 28 2015

kutuzov.viktor.84 retitled D7233: [Sanitizers] Introduce GET_LINK_MAP_BY_DLOPEN_HANDLE() macro from to [Sanitizers] Fix ForEachMappedRegion() to work on FreeBSD.
Jan 28 2015, 11:30 AM
kutuzov.viktor.84 added a comment to D6892: [Sanitizers] Order initialization of coverage and guard arrays.

OK, it makes sense, thanks. However, while it works for Asan's __asan_init()t called from the code injected by the instrumentation part, it doesn't work for UBsan where, in omission of SANITIZER_CAN_USE_PREINIT_ARRAY, __ubsan::InitIfNecessary() is called from a regular constructor which has a lower priority than __sanitizer_cov_module_init. Maybe we should introduce instrumentation for UBsan or just replace the ubsan_initializer declaration:

class UbsanInitializer {
 public:
  UbsanInitializer() {
    InitIfNecessary();
  }
};
static UbsanInitializer ubsan_initializer;
Jan 28 2015, 8:15 AM

Jan 26 2015

kutuzov.viktor.84 added a comment to D6892: [Sanitizers] Order initialization of coverage and guard arrays.

I think the right fix would be reverting this change and lowering the priority of the coverate module initializer to 2 (keeping __asan_init at 1).

Jan 26 2015, 9:39 AM

Jan 23 2015

kutuzov.viktor.84 retitled D7145: [Msan] Disable the ppoll unit test on FreeBSD from to [Msan] Disable the ppoll unit test on FreeBSD.
Jan 23 2015, 6:48 AM
kutuzov.viktor.84 retitled D7144: [Msan] Fix the statfs unit test to pass on FreeBSD from to [Msan] Fix the statfs unit test to pass on FreeBSD.
Jan 23 2015, 6:47 AM

Jan 21 2015

kutuzov.viktor.84 updated the diff for D7091: [Msan] Fix the readv and preadv unit tests to pass on FreeBSD.

Updated to cover the preadv test.

Jan 21 2015, 4:57 AM
kutuzov.viktor.84 retitled D7091: [Msan] Fix the readv and preadv unit tests to pass on FreeBSD from to [Msan] Fix the readv unit test to pass on FreeBSD.
Jan 21 2015, 4:27 AM
kutuzov.viktor.84 added inline comments to D7089: [Msan] Fix the strerror_r unit test to build on FreeBSD.
Jan 21 2015, 3:56 AM
kutuzov.viktor.84 retitled D7089: [Msan] Fix the strerror_r unit test to build on FreeBSD from to [Msan] Fix the strerror_r unit test to build on FreeBSD.
Jan 21 2015, 3:54 AM
kutuzov.viktor.84 retitled D7086: [Msan] Fix the DynRet unit test to build on FreeBSD from to [Msan] Fix the DynRet unit test to build on FreeBSD.
Jan 21 2015, 3:30 AM
kutuzov.viktor.84 retitled D7084: [Sanitizers] Fix inet_aton() and inet_pton() interceptors to work on FreeBSD from to [Sanitizers] Fix inet_aton() and inet_pton() interceptors to work on FreeBSD.
Jan 21 2015, 3:01 AM
kutuzov.viktor.84 retitled D7083: [Msan] Fix the accept unit test to pass on FreeBSD from to [Msan] Fix the accept unit test to pass on FreeBSD.
Jan 21 2015, 1:08 AM

Jan 20 2015

kutuzov.viktor.84 updated the diff for D6968: [Sanitizers] Intercept opendir().

Updated.

Jan 20 2015, 3:33 AM

Jan 19 2015

kutuzov.viktor.84 retitled D7052: [Msan] Fix the readlink unit test to pass on FreeBSD from to [Msan] Fix the readlink unit test to pass on FreeBSD.
Jan 19 2015, 5:33 AM
kutuzov.viktor.84 retitled D7051: [Msan] Intercept stat() and fstatat() on FreeBSD from to [Msan] Intercept stat() and fstatat() on FreeBSD.
Jan 19 2015, 4:37 AM
kutuzov.viktor.84 updated the diff for D6968: [Sanitizers] Intercept opendir().

Updated.

Jan 19 2015, 3:04 AM

Jan 16 2015

kutuzov.viktor.84 updated the diff for D6892: [Sanitizers] Order initialization of coverage and guard arrays.

Updated.

Jan 16 2015, 6:47 AM
kutuzov.viktor.84 updated the diff for D6968: [Sanitizers] Intercept opendir().
  • The opendir() interceptor moved to Msan so it doesn't interfere with the Tsan's one;
  • The comment fixed to mention internal structures that cause false positives;
  • A test added.
Jan 16 2015, 6:36 AM
kutuzov.viktor.84 planned changes to D6968: [Sanitizers] Intercept opendir().

If opendir() calls strlen(), which we already intersept, won't we see the access w/o this interceptor?

Jan 16 2015, 6:32 AM

Jan 14 2015

kutuzov.viktor.84 retitled D6968: [Sanitizers] Intercept opendir() from to [Sanitizers] Intercept opendir().
Jan 14 2015, 8:17 AM

Jan 12 2015

kutuzov.viktor.84 retitled D6929: [Msan] Fix use of mmap(MAP_ANONYMOUS) in the unit tests on FreeBSD from to [Msan] Fix use of mmap(MAP_ANONYMOUS) in the unit tests on FreeBSD.
Jan 12 2015, 9:46 AM
kutuzov.viktor.84 retitled D6928: [Msan] Fix strlen() and strnlen() interceptors to work on FreeBSD from to [Msan] Fix strlen() and strnlen() interceptors to work on FreeBSD.
Jan 12 2015, 9:04 AM
kutuzov.viktor.84 retitled D6926: [Msan] Fix tests reading /proc files on FreeBSD from to [Msan] Fix tests reading /proc files on FreeBSD.
Jan 12 2015, 8:15 AM

Jan 10 2015

kutuzov.viktor.84 added a comment to D6892: [Sanitizers] Order initialization of coverage and guard arrays.

Could you please remind us why we can't guarantee this?

Jan 10 2015, 1:26 AM

Jan 9 2015

kutuzov.viktor.84 retitled D6892: [Sanitizers] Order initialization of coverage and guard arrays from to [Sanitizers] Order initialization of coverage and guard arrays.
Jan 9 2015, 5:01 AM

Jan 7 2015

kutuzov.viktor.84 updated the diff for D6825: [Sanitizers] Fix internal_lseek() to work on FreeBSD.

Comment fixed. Thanks Ed.

Jan 7 2015, 4:05 AM

Jan 2 2015

kutuzov.viktor.84 retitled D6825: [Sanitizers] Fix internal_lseek() to work on FreeBSD from to [Sanitizers] Fix internal_lseek() to work on FreeBSD.
Jan 2 2015, 4:28 AM

Dec 22 2014

kutuzov.viktor.84 retitled D6757: [Msan] Fix msan_test.cc inclusions to build the unit tests on FreeBSD from to [Msan] Fix msan_test.cc inclusions to build the unit tests on FreeBSD.
Dec 22 2014, 6:38 AM
kutuzov.viktor.84 added a comment to D6755: [Sanitizers] Intercept wcsnrtombs() on FreeBSD.

Understood. Thanks.

Dec 22 2014, 5:25 AM
kutuzov.viktor.84 retitled D6755: [Sanitizers] Intercept wcsnrtombs() on FreeBSD from to [Sanitizers] Intercept wcsnrtombs() on FreeBSD.
Dec 22 2014, 5:13 AM

Dec 19 2014

kutuzov.viktor.84 retitled D6738: [Msan] Fix uname() interception on FreeBSD from to [Msan] Fix uname() interception on FreeBSD.
Dec 19 2014, 8:24 AM
kutuzov.viktor.84 retitled D6737: [Sanitizers] Intercept wordexp on FreeBSD from to [Sanitizers] Intercept wordexp on FreeBSD.
Dec 19 2014, 6:00 AM
kutuzov.viktor.84 updated the diff for D6418: [Sanitizers] Intercept snprintf_l() on FreeBSD.

Updated. Thanks, Evgeniy.

Dec 19 2014, 4:13 AM