This is an archive of the discontinued LLVM Phabricator instance.

lib/sanitizer_common/sanitizer_linux.cc
63	Shouldn't it be included on linux as well? I guess it is included by some other header on linux, but it is not a reason to not include it explicitly if we use it.

Updated.

LGTM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

sanitizer_common/

1 line

	Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
	#include <sys/resource.h>			#include <sys/resource.h>
	#include <sys/stat.h>			#include <sys/stat.h>
	#include <sys/syscall.h>			#include <sys/syscall.h>
	#include <sys/time.h>			#include <sys/time.h>
	#include <sys/types.h>			#include <sys/types.h>
	#include <unistd.h>			#include <unistd.h>

	#if SANITIZER_FREEBSD			#if SANITIZER_FREEBSD
				#include <ucontext.h>
				dvyukovUnsubmitted Not Done Reply Inline Actions Shouldn't it be included on linux as well? I guess it is included by some other header on linux, but it is not a reason to not include it explicitly if we use it. dvyukov: Shouldn't it be included on linux as well? I guess it is included by some other header on linux…
	#include <sys/sysctl.h>			#include <sys/sysctl.h>
	#include <machine/atomic.h>			#include <machine/atomic.h>
	extern "C" {			extern "C" {
	// <sys/umtx.h> must be included after <errno.h> and <sys/types.h> on			// <sys/umtx.h> must be included after <errno.h> and <sys/types.h> on
	// FreeBSD 9.2 and 10.0.			// FreeBSD 9.2 and 10.0.
	#include <sys/umtx.h>			#include <sys/umtx.h>
	}			}
	extern char **environ; // provided by crt1			extern char **environ; // provided by crt1
	▲ Show 20 Lines • Show All 937 Lines • Show Last 20 Lines