Page MenuHomePhabricator

Install the MLIRTableGen static library.
ClosedPublic

Authored by stellaraccident on Thu, Jun 11, 2:10 PM.

Details

Summary
  • This library is special because of its dependencies so seems to have been inadvertently left out of installs.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
antiagainst accepted this revision.Thu, Jun 11, 3:49 PM
This revision is now accepted and ready to land.Thu, Jun 11, 3:49 PM
stephenneuendorffer added inline comments.
mlir/lib/TableGen/CMakeLists.txt
37

Guard this on LLVM_INSTALL_UTILITIES?

stellaraccident marked an inline comment as done.Thu, Jun 11, 6:18 PM
stellaraccident added inline comments.
mlir/lib/TableGen/CMakeLists.txt
37

I *think* it shouldn't be guarded (isn't that guard for installing the actual binaries?). This is just a library, that as near as I can tell should install with the same rules as every other MLIR library, but due to the way it needs to be built can't use add_mlir_library to take care of that.

This revision was automatically updated to reflect the committed changes.