[analyzer] SATest: Make docker interfaces transparent

[vsavchenko]

Summary

Forward results of every command executed in docker. The actual commands
and their error codes are more informative than python stacktraces.

[NoQ]

Yay transparency.

clang/utils/analyzer/SATest.py

 #!/usr/bin/env python
 
 import SATestAdd
 import SATestBuild
 import SATestUpdateDiffs
 import CmpRuns
 
 from ProjectMap import ProjectInfo, ProjectMap
 
 import argparse
 import sys
 import os
 
-from subprocess import check_call
+from subprocess import call
 
 SCRIPTS_DIR = os.path.dirname(os.path.realpath(__file__))
 PROJECTS_DIR = os.path.join(SCRIPTS_DIR, "projects")
 DEFAULT_LLVM_DIR = os.path.realpath(os.path.join(SCRIPTS_DIR,
                                                  os.path.pardir,
                                                  os.path.pardir,
                                                  os.path.pardir))
 
def docker(parser, args):
 
     if args.build_image:
         docker_build_image()
     else:
         docker_run(args)
 
 
 def docker_build_image():
-    check_call("docker build --tag satest-image {}".format(SCRIPTS_DIR),
-               shell=True)
+    sys.exit(call("docker build --tag satest-image {}".format(SCRIPTS_DIR),
+                  shell=True))
 
 
 def docker_run(args):
-    check_call("docker run --rm --name satest "
+    sys.exit(call("docker run --rm --name satest "
                   "-v {llvm}:/llvm-project "
                   "-v {build}:/build "
                   "-v {clang}:/analyzer "
                   "-v {scripts}:/scripts "
                   "-v {projects}:/projects "
                   "satest-image:latest {args}"
-               .format(llvm=args.llvm_project_dir, build=args.build_dir,
-                       clang=args.clang_dir, scripts=SCRIPTS_DIR,
-                       projects=PROJECTS_DIR, args=' '.join(args.rest)),
-               shell=True)
+                  .format(llvm=args.llvm_project_dir,
+                          build=args.build_dir,
+                          clang=args.clang_dir,
+                          scripts=SCRIPTS_DIR,
+                          projects=PROJECTS_DIR,
+                          args=' '.join(args.rest)),
+                  shell=True))
 
 
 def main():
     parser = argparse.ArgumentParser()
     subparsers = parser.add_subparsers()
 
     # add subcommand
     add_parser = subparsers.add_parser(

clang/utils/analyzer/entrypoint.py

 import argparse
 import os
+import sys
 
 from typing import List, Tuple
 
-from subprocess import check_call
+from subprocess import call, check_call, CalledProcessError
 
 
 def main():
     settings, rest = parse_arguments()
     if settings.build_llvm or settings.build_llvm_only:
         build_llvm()
     if settings.build_llvm_only:
         return
-    test(rest)
+    sys.exit(test(rest))
 
 
 def parse_arguments() -> Tuple[argparse.Namespace, List[str]]:
     parser = argparse.ArgumentParser()
     parser.add_argument('--build-llvm', action='store_true')
     parser.add_argument('--build-llvm-only', action='store_true')
     return parser.parse_known_args()
 
 
 def build_llvm() -> None:
     os.chdir('/build')
+    try:
         cmake()
         ninja()
+    except CalledProcessError:
+        print("Build failed!")
+        sys.exit(1)
 
 
 CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \
     "-DCMAKE_INSTALL_PREFIX=/analyzer -DLLVM_TARGETS_TO_BUILD=X86 " \
     "-DLLVM_ENABLE_PROJECTS=clang -DLLVM_BUILD_RUNTIME=OFF " \
     "-DLLVM_ENABLE_TERMINFO=OFF -DCLANG_ENABLE_ARCMT=OFF " \
     "-DCLANG_ENABLE_STATIC_ANALYZER=ON"
 
 
 def cmake():
     check_call(CMAKE_COMMAND + ' /llvm-project/llvm', shell=True)
 
 
 def ninja():
     check_call("ninja install", shell=True)
 
 
-def test(args: List[str]):
+def test(args: List[str]) -> int:
     os.chdir("/projects")
-    check_call("/scripts/SATest.py " + " ".join(args), shell=True)
+    return call("/scripts/SATest.py " + " ".join(args), shell=True)
 
 
 if __name__ == '__main__':
     main()