Page MenuHomePhabricator

[libc++] Work around gcc/Power9 bug in `include/thread`
ClosedPublic

Authored by jdenny on Jun 8 2020, 4:32 PM.

Details

Summary

This fixes PR39696, which breaks the libcxx build with gcc (I tested
7.5.0) on Power9. This fix was suggested at

https://bugs.llvm.org/show_bug.cgi?id=39696#c38

but never applied. It just reverts 0583d9ea8d5e, which reverses
components of the original fix in 3bf63cf3b366, which is correct.

Fixes https://llvm.org/PR39696

Diff Detail

Event Timeline

jdenny created this revision.Jun 8 2020, 4:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 4:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 9 2020, 7:55 AM
ldionne added a subscriber: ldionne.

Can you confirm that basically 0583d9ea8d5edc60d84971ced29db042b59302ba should not have been committed, since the original fix 3bf63cf3b366d3a57cf5cbad4112a6abf6c0c3b1 was correct in the first place. And all this does is revert 0583d9ea8d5edc60d84971ced29db042b59302ba.

I did read the bug report discussion and that is my understanding, I just want to double check because the bug report discussion is tortuous. If I got that right, LGTM.

This revision is now accepted and ready to land.Jun 9 2020, 7:55 AM
jdenny edited the summary of this revision. (Show Details)Jun 9 2020, 8:13 AM

Can you confirm that basically 0583d9ea8d5edc60d84971ced29db042b59302ba should not have been committed, since the original fix 3bf63cf3b366d3a57cf5cbad4112a6abf6c0c3b1 was correct in the first place. And all this does is revert 0583d9ea8d5edc60d84971ced29db042b59302ba.

Yes, that's my understanding (and I just checked that git revert produces the same result). I've updated the summary to clarify this.

I did read the bug report discussion and that is my understanding, I just want to double check because the bug report discussion is tortuous. If I got that right, LGTM.

Thanks for the quick review.

Thanks for the confirmation. Ship it, and please update the bug report :-)

This revision was automatically updated to reflect the committed changes.