This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Deprecate dead code from CallingConvLower.h
ClosedPublic

Authored by gchatelet on Jun 8 2020, 12:29 AM.

Diff Detail

Unit TestsFailed

Event Timeline

gchatelet created this revision.Jun 8 2020, 12:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 12:29 AM

Shouldn't this undergo a deprecation cycle ? This is a public header.

gchatelet updated this revision to Diff 269171.Jun 8 2020, 4:25 AM

Deprecate functions and amend commit message

gchatelet retitled this revision from [Alignment][NFC] Remove dead code from CallingConvLower.h to [Alignment][NFC] Deprecate dead code from CallingConvLower.h.Jun 8 2020, 4:26 AM
courbet accepted this revision.Jun 8 2020, 5:34 AM
This revision is now accepted and ready to land.Jun 8 2020, 5:34 AM
This revision was automatically updated to reflect the committed changes.

It looks like this function isn't actually dead code. I'm getting a ton of deprecation warnings about it on my master build, and this build bot run from one commit after yours that fixed the build failure has a bunch: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/17308

I thought the build bots built with -werror? How are these builds passing?

gchatelet added a comment.EditedJun 9 2020, 1:06 AM

It looks like this function isn't actually dead code. I'm getting a ton of deprecation warnings about it on my master build, and this build bot run from one commit after yours that fixed the build failure has a bunch: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/17308

I thought the build bots built with -werror? How are these builds passing?

Thx for the heads up. I fixed it in rG49dd8e79913cc10676902fd2033a090758cf9b90.

As for the bots, there's a difference in how the deprecated attribute is treated between GCC/Clang and MSVC. For MSVC the warning triggers even if the faulty call is inside a deprecated method itself, it's not the case for Clang/GCC, so depending on which bot is running it triggers an error... or not.

For MSVC the warning triggers even if the faulty call is inside a deprecated method itself

Wow, really? Eww...

Either way, thanks for taking a look!