This is an archive of the discontinued LLVM Phabricator instance.

Differential D81328

[mlir] Restructure Shape dialect's CMakeLists.
ClosedPublic

Authored by tpopp on Jun 6 2020, 1:18 AM.

Details

Reviewers
isuruf
silvas
Commits
rG5d77bd733ee6: [mlir] Restructure Shape dialect's CMakeLists.
Summary

Now targets are only built with files in the same directory.

Diff Detail

Event Timeline

tpopp created this revision.Jun 6 2020, 1:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2020, 1:18 AM
Herald added subscribers: msifontes, jurahul, Kayjukh and 16 others. · View Herald Transcript
Harbormaster completed remote builds in B59363: Diff 268999.Jun 6 2020, 2:38 AM
isuruf accepted this revision.Jun 6 2020, 8:28 AM

Works for me.

This revision is now accepted and ready to land.Jun 6 2020, 8:28 AM
silvas accepted this revision.Jun 6 2020, 11:27 AM

Thanks!!!

Closed by commit rG5d77bd733ee6: [mlir] Restructure Shape dialect's CMakeLists. (authored by Tres Popp <tpopp@google.com>). · Explain WhyJun 8 2020, 1:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Shape/
17 lines
IR/
2 lines

Diff 269116

mlir/lib/Dialect/Shape/CMakeLists.txt

  • This file was copied to mlir/lib/Dialect/Shape/IR/CMakeLists.txt.
add_mlir_dialect_library(MLIRShape add_subdirectory(IR)
IR/Shape.cpp
ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Shape
DEPENDS
MLIRShapeOpsIncGen
LINK_LIBS PUBLIC
MLIRControlFlowInterfaces
MLIRDialect
MLIRInferTypeOpInterface
MLIRIR
MLIRSideEffectInterfaces
)

mlir/lib/Dialect/Shape/IR/CMakeLists.txt

  • This file was copied from mlir/lib/Dialect/Shape/CMakeLists.txt.
add_mlir_dialect_library(MLIRShape add_mlir_dialect_library(MLIRShape
IR/Shape.cpp Shape.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Shape ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Shape
DEPENDS DEPENDS
MLIRShapeOpsIncGen MLIRShapeOpsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRDialect MLIRDialect
MLIRInferTypeOpInterface MLIRInferTypeOpInterface
MLIRIR MLIRIR
MLIRSideEffectInterfaces MLIRSideEffectInterfaces
) )