Page MenuHomePhabricator

[hwasan] Disable malloc-fill by default.
ClosedPublic

Authored by eugenis on Jun 5 2020, 10:59 AM.

Details

Summary

Non-zero malloc fill is causing way too many hard to debug issues.

Diff Detail

Unit TestsFailed

TimeTest
150 mslinux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fvisibility=hidden -c -DTU1 -o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/anon-namespace.cpp.tmp1.o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/compiler-rt/test/cfi/anon-namespace.cpp
120 mslinux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fvisibility=hidden -o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/bad-cast.cpp.tmp1 /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/compiler-rt/test/cfi/bad-cast.cpp
100 mslinux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fvisibility=hidden -o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/bad-split.cpp.tmp1 /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/compiler-rt/test/cfi/bad-split.cpp && /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/bad-split.cpp.tmp1
110 mslinux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fvisibility=hidden -o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/base-derived-destructor.cpp.tmp1 /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/compiler-rt/test/cfi/base-derived-destructor.cpp
90 mslinux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::Unknown Unit Message ("")
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/./bin/clang -m64 -fuse-ld=lld -flto=thin -fsanitize=cfi -fwhole-program-vtables --driver-mode=g++ -fvisibility=hidden -fno-sanitize-trap=cfi -fsanitize-recover=cfi -g -DSHARED_LIB -fPIC -shared -o /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/build/projects/compiler-rt/test/cfi/Devirt-lld-thinlto-x86_64/Output/libcross-dso-diagnostic.cpp.dynamic.so /mnt/disks/ssd0/agent/premerge-debian-5d5d95fcbb-ts6dn-2/llvm-project/premerge-checks/compiler-rt/test/cfi/cross-dso-diagnostic.cpp
View Full Test Results (114 Failed)

Event Timeline

eugenis created this revision.Jun 5 2020, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 10:59 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kcc accepted this revision.Jun 5 2020, 11:14 AM

LGTM (even though it's sad...)

This revision is now accepted and ready to land.Jun 5 2020, 11:14 AM
hctim accepted this revision.Jun 5 2020, 11:35 AM
This revision was automatically updated to reflect the committed changes.