This is an archive of the discontinued LLVM Phabricator instance.

Differential D81265

[CMake] Do not append -lm to CMAKE_REQUIRED_LIBRARIES on Apple
ClosedPublic

Authored by ldionne on Jun 5 2020, 8:14 AM.

Details

Reviewers
smeenai
Commits
rGf57dd4156234: [CMake] Do not append -lm to CMAKE_REQUIRED_LIBRARIES on Apple
Summary

On Apple platforms, linking against libSystem.dylib is sufficient, and
some Apple platforms don't provide libm.dylib. On those platforms, adding
-lm to CMAKE_REQUIRED_LIBRARIES causes all subsequent compile-flag checks
to fail due to the missing library.

Diff Detail

Event Timeline

ldionne created this revision.Jun 5 2020, 8:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 8:14 AM
Herald added subscribers: llvm-commits, dexonsmith, jkorous, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B59255: Diff 268805.Jun 5 2020, 9:28 AM
smeenai accepted this revision.Jun 5 2020, 9:44 AM

LGTM

This revision is now accepted and ready to land.Jun 5 2020, 9:44 AM
Closed by commit rGf57dd4156234: [CMake] Do not append -lm to CMAKE_REQUIRED_LIBRARIES on Apple (authored by ldionne). · Explain WhyJun 5 2020, 10:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
cmake/
2 lines

Diff 268862

llvm/cmake/config-ix.cmake

if( WIN32 AND NOT CYGWIN ) if( WIN32 AND NOT CYGWIN )
# We consider Cygwin as another Unix # We consider Cygwin as another Unix
set(PURE_WINDOWS 1) set(PURE_WINDOWS 1)
endif() endif()
include(CheckIncludeFile) include(CheckIncludeFile)
include(CheckLibraryExists) include(CheckLibraryExists)
include(CheckSymbolExists) include(CheckSymbolExists)
include(CheckFunctionExists) include(CheckFunctionExists)
include(CheckStructHasMember) include(CheckStructHasMember)
include(CheckCCompilerFlag) include(CheckCCompilerFlag)
include(CheckCompilerVersion) include(CheckCompilerVersion)
include(HandleLLVMStdlib) include(HandleLLVMStdlib)
if( UNIX AND NOT (BEOS OR HAIKU) ) if( UNIX AND NOT (APPLE OR BEOS OR HAIKU) )
# Used by check_symbol_exists: # Used by check_symbol_exists:
list(APPEND CMAKE_REQUIRED_LIBRARIES "m") list(APPEND CMAKE_REQUIRED_LIBRARIES "m")
endif() endif()
# x86_64 FreeBSD 9.2 requires libcxxrt to be specified explicitly. # x86_64 FreeBSD 9.2 requires libcxxrt to be specified explicitly.
if( CMAKE_SYSTEM MATCHES "FreeBSD-9.2-RELEASE" AND if( CMAKE_SYSTEM MATCHES "FreeBSD-9.2-RELEASE" AND
CMAKE_SIZEOF_VOID_P EQUAL 8 ) CMAKE_SIZEOF_VOID_P EQUAL 8 )
list(APPEND CMAKE_REQUIRED_LIBRARIES "cxxrt") list(APPEND CMAKE_REQUIRED_LIBRARIES "cxxrt")
endif() endif()
▲ Show 20 Lines • Show All 646 Lines • Show Last 20 Lines