Page MenuHomePhabricator

[mlir][Vector] Move temporary alloc to top of the function alloca when lowering vector_transfers
ClosedPublic

Authored by nicolasvasilache on Jun 5 2020, 4:58 AM.

Details

Summary

Recently introduced allocation hoisting is quite conservative on the cases when it triggers.
This revision makes it such that the allocations for vector transfer lowerings are hoisted
to the top of the function.
This should be revisited in the context of parallelism and is a temporary workaround.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
ftynse accepted this revision.Jun 5 2020, 5:01 AM
ftynse added inline comments.
mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
200

static

This revision is now accepted and ready to land.Jun 5 2020, 5:01 AM

Address review.

nicolasvasilache marked an inline comment as done.Jun 5 2020, 5:26 AM
This revision was automatically updated to reflect the committed changes.