This is an archive of the discontinued LLVM Phabricator instance.

Correctly report modified status for LoopSimplify
ClosedPublic

Authored by serge-sans-paille on Jun 5 2020, 12:45 AM.

Reviewers

Commits

Summary

Looks obviously correct.

This revision is now accepted and ready to land.Jun 5 2020, 6:06 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Utils/

1 line

Show First 20 Lines • Show All 613 Lines • ▼ Show 20 Lines	ReprocessLoop:
PHINode *PN;		PHINode *PN;
for (BasicBlock::iterator I = L->getHeader()->begin();		for (BasicBlock::iterator I = L->getHeader()->begin();
(PN = dyn_cast<PHINode>(I++)); )		(PN = dyn_cast<PHINode>(I++)); )
if (Value *V = SimplifyInstruction(PN, {DL, nullptr, DT, AC})) {		if (Value *V = SimplifyInstruction(PN, {DL, nullptr, DT, AC})) {
if (SE) SE->forgetValue(PN);		if (SE) SE->forgetValue(PN);
if (!PreserveLCSSA \|\| LI->replacementPreservesLCSSAForm(PN, V)) {		if (!PreserveLCSSA \|\| LI->replacementPreservesLCSSAForm(PN, V)) {
PN->replaceAllUsesWith(V);		PN->replaceAllUsesWith(V);
PN->eraseFromParent();		PN->eraseFromParent();
		Changed = true;
}		}
}		}

// If this loop has multiple exits and the exits all go to the same		// If this loop has multiple exits and the exits all go to the same
// block, attempt to merge the exits. This helps several passes, such		// block, attempt to merge the exits. This helps several passes, such
// as LoopRotation, which do not support loops with multiple exits.		// as LoopRotation, which do not support loops with multiple exits.
// SimplifyCFG also does this (and this code uses the same utility		// SimplifyCFG also does this (and this code uses the same utility
// function), however this code is loop-aware, where SimplifyCFG is		// function), however this code is loop-aware, where SimplifyCFG is
▲ Show 20 Lines • Show All 322 Lines • Show Last 20 Lines