This is an archive of the discontinued LLVM Phabricator instance.

Correctly report modified status for DivRemPairs
ClosedPublic

Authored by serge-sans-paille on Jun 5 2020, 12:37 AM.

Reviewers

Commits

Summary

Oops, LG.

This revision is now accepted and ready to land.Jun 5 2020, 1:32 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Scalar/

1 line

Show First 20 Lines • Show All 215 Lines • ▼ Show 20 Lines	if (HasDivRemOp && E.isRemExpanded()) {
// Update AssertingVH<> with new instruction so it doesn't assert.		// Update AssertingVH<> with new instruction so it doesn't assert.
RemInst = RealRem;		RemInst = RealRem;
// And replace the original instruction with the new one.		// And replace the original instruction with the new one.
OrigRemInst->replaceAllUsesWith(RealRem);		OrigRemInst->replaceAllUsesWith(RealRem);
OrigRemInst->eraseFromParent();		OrigRemInst->eraseFromParent();
NumRecomposed++;		NumRecomposed++;
// Note that we have left ((X / Y) * Y) around.		// Note that we have left ((X / Y) * Y) around.
// If it had other uses we could rewrite it as X - X % Y		// If it had other uses we could rewrite it as X - X % Y
		Changed = true;
}		}

assert((!E.isRemExpanded() \|\| !HasDivRemOp) &&		assert((!E.isRemExpanded() \|\| !HasDivRemOp) &&
"If the target supports div-rem, then by now the RemInst is "		"If the target supports div-rem, then by now the RemInst is "
"Instruction::[US]Rem.");		"Instruction::[US]Rem.");

// If the target supports div+rem and the instructions are in the same block		// If the target supports div+rem and the instructions are in the same block
// already, there's nothing to do. The backend should handle this. If the		// already, there's nothing to do. The backend should handle this. If the
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines