Implementations of copysign[f], frexp[f], logb[f], and modf[f] are added.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice work. I would just make sure that the tests cover all control-flow paths.
libc/test/src/math/frexp_test.cpp | ||
---|---|---|
101 | I would add one test with a different base than 0.5/-0.5 (e.g. 0.75, input value 24). You can also reduce the amount of 0.5 tests if you want to. The same with the float version. | |
libc/test/src/math/logb_test.cpp | ||
68 | I would add one more test of a value that is not 2^(integer). | |
libc/test/src/math/modf_test.cpp | ||
86 | Wouldn't it be useful to have also one test where the fractional part is non-zero (e.g. 0.5)? The same also for modff. |
I would add one test with a different base than 0.5/-0.5 (e.g. 0.75, input value 24). You can also reduce the amount of 0.5 tests if you want to. The same with the float version.