Page MenuHomePhabricator

[clangd] Populate the parse options to CodeCompletion/SignatureHelp.
ClosedPublic

Authored by hokein on Jun 3 2020, 1:39 AM.

Diff Detail

Event Timeline

hokein created this revision.Jun 3 2020, 1:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2020, 1:39 AM
sammccall accepted this revision.Jun 3 2020, 3:28 AM
sammccall added inline comments.
clang-tools-extra/clangd/CodeComplete.cpp
1108

this change looks suspicious, really needed?

clang-tools-extra/clangd/Compiler.h
57

this is the default already - only need to do this for scalar types that would otherwise have indeterminate default

This revision is now accepted and ready to land.Jun 3 2020, 3:28 AM
hokein updated this revision to Diff 268164.Jun 3 2020, 6:13 AM
hokein marked 2 inline comments as done.

Revert an accident change.

hokein added inline comments.Jun 3 2020, 6:16 AM
clang-tools-extra/clangd/CodeComplete.cpp
1108

oops, I think this is an accident change, reverted.

clang-tools-extra/clangd/Compiler.h
57

yeah, exactly, however clang was not happy with the ParseInputs {Command, FS, contents} usage, it gave -Wmissing-field-initializers warning.

This revision was automatically updated to reflect the committed changes.