Page MenuHomePhabricator

[clangd] Add a flag to preserve type for recovery expression.
ClosedPublic

Authored by hokein on May 14 2020, 5:06 AM.

Diff Detail

Event Timeline

hokein created this revision.May 14 2020, 5:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2020, 5:06 AM
hokein marked an inline comment as done.May 14 2020, 5:10 AM
hokein added inline comments.
clang-tools-extra/clangd/CodeComplete.cpp
1072

unfortunately, we don't have the ParseOptions structure in code completion code path, maybe we can add two flags in SemaCompleteInput.

sammccall accepted this revision.May 18 2020, 12:05 PM
sammccall added inline comments.
clang-tools-extra/clangd/CodeComplete.cpp
1072

I think we should just make the public interface to codeComplete take ParseInputs, it's mostly overlap anyway

This revision is now accepted and ready to land.May 18 2020, 12:05 PM
This revision was automatically updated to reflect the committed changes.