[Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

[jkorous]

Summary

isRefCountable asserts that the record passed as an argument has a definition available.

Fixes https://bugs.llvm.org/show_bug.cgi?id=46142

[NoQ]

Yup, i think that's reasonable.

clang/lib/StaticAnalyzer/Checkers/WebKit/NoUncountedMembersChecker.cpp

if (shouldSkipDecl(RD))
       return;
 
     for (auto Member : RD->fields()) {
       const Type *MemberType = Member->getType().getTypePtrOrNull();
       if (!MemberType)
         continue;
 
       if (auto *MemberCXXRD = MemberType->getPointeeCXXRecordDecl()) {
-        if (isRefCountable(MemberCXXRD))
+        // If we don't see the definition we just don't know.
+        if (MemberCXXRD->hasDefinition() && isRefCountable(MemberCXXRD))
           reportBug(Member, MemberType, MemberCXXRD, RD);
       }
     }
   }
 
   bool shouldSkipDecl(const RecordDecl *RD) const {
     if (!RD->isThisDeclarationADefinition())
       return true;

clang/test/Analysis/Checkers/WebKit/uncounted-members-regression-46142.cpp

+// regression test for https://bugs.llvm.org/show_bug.cgi?id=46142
+
+// RUN: %clang_analyze_cc1 -analyzer-checker=webkit.WebKitNoUncountedMemberChecker -verify %s
+// expected-no-diagnostics
+
+class ClassWithoutADefinition;
+class Foo {
+    const ClassWithoutADefinition *foo;
+};