This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Make G_IMPLICIT_DEF legality more consistent
ClosedPublic

Authored by arsenm on May 31 2020, 7:56 AM.

Details

Summary

Makes <6 x s16> legal, <4 x s8> illegal, and clamps the maximum size
to 1024.

Diff Detail

Event Timeline

arsenm created this revision.May 31 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2020, 7:56 AM
foad added inline comments.Jun 8 2020, 5:43 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fdiv.mir
215 ↗(On Diff #267498)

All these changes are unrelated.

arsenm marked an inline comment as done.Jun 8 2020, 6:15 AM
arsenm added inline comments.
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fdiv.mir
215 ↗(On Diff #267498)

One of the issues with update_*test_checks scripts is they don't match the end of the line, so they miss new additions at the end. I can precommit a no-op regenerate these

foad accepted this revision.Jun 10 2020, 3:10 AM

I'm not really an expert but it looks good to me.

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
465

Typo "don't don't".

This revision is now accepted and ready to land.Jun 10 2020, 3:10 AM
arsenm closed this revision.Jun 10 2020, 8:06 AM