This is an archive of the discontinued LLVM Phabricator instance.

Remove WrapperMatcherInterface
ClosedPublic

Authored by gribozavr on May 28 2020, 2:53 AM.

Details

Summary

WrapperMatcherInterface is an abstraction over a member variable -- in
other words, not much of an abstraction at all. I think it makes code
harder to read more than in helps with deduplication. Not to even
mention the questionable usage of the ~Interface suffix for a type with
state.

Diff Detail

Unit TestsFailed

Event Timeline

gribozavr created this revision.May 28 2020, 2:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2020, 2:53 AM
ymandel accepted this revision.May 28 2020, 6:14 AM

Yes, thank you! There are (IMO) too many layers of abstractions in this framework; this is a good step in the right direction. :)

This revision is now accepted and ready to land.May 28 2020, 6:14 AM
This revision was automatically updated to reflect the committed changes.