This is an archive of the discontinued LLVM Phabricator instance.

Differential D80664

[mlir][Linalg] Add missing library linkage for shared library builds.
ClosedPublic

Authored by mravishankar on May 27 2020, 2:13 PM.

Details

Reviewers
nicolasvasilache
Commits
rG0a072b8a0da7: [mlir][Linalg] Add missing library linkage for shared library builds.

Diff Detail

Event Timeline

mravishankar created this revision.May 27 2020, 2:13 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 27 2020, 2:13 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, jurahul, Kayjukh and 16 others. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 27 2020, 2:43 PM
Closed by commit rG0a072b8a0da7: [mlir][Linalg] Add missing library linkage for shared library builds. (authored by mravishankar). · Explain Why
This revision was automatically updated to reflect the committed changes.
mravishankar added a comment.May 27 2020, 2:45 PM

Submitted as fix for linking error when building shared libraries.

Harbormaster failed remote builds in B58115: Diff 266668!May 28 2020, 2:08 AM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Linalg/
Utils/
1 line

Diff 266668

mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt

add_mlir_dialect_library(MLIRLinalgUtils add_mlir_dialect_library(MLIRLinalgUtils
Utils.cpp Utils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffineOps
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgEDSC
MLIRLinalgOps MLIRLinalgOps
MLIRSCF MLIRSCF
MLIRPass MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRTransformUtils MLIRTransformUtils
) )