[libc++] Mark __cpp_lib_hardware_interference_size as unimplemented. This fxes bug PR41423.

[curdeius]

Summary

As described in the bug report:
The commit a8b9f59e8caf378d56e8bfcecdb22184cdabf42d "Implement feature test macros using a script" added test features macros for libc++. Among others, it added __cpp_lib_hardware_interference_size. However, there is nothing like std::hardware_constructive_interference_size nor std::hardware_destructive_interference_size, that should be in header <new>.

• https://bugs.llvm.org/show_bug.cgi?id=41423

[ldionne]

It does seem to be a mistake. Thanks for fixing it!

libcxx/docs/FeatureTestMacroTable.rst

.. table:: Current Status
     ``__cpp_lib_enable_shared_from_this``             ``201603L``      
     ------------------------------------------------- -----------------
     ``__cpp_lib_execution``                           *unimplemented*  
     ------------------------------------------------- -----------------
     ``__cpp_lib_filesystem``                          ``201703L``      
     ------------------------------------------------- -----------------
     ``__cpp_lib_gcd_lcm``                             ``201606L``      
     ------------------------------------------------- -----------------
-    ``__cpp_lib_hardware_interference_size``          ``201703L``      
+    ``__cpp_lib_hardware_interference_size``          *unimplemented*  
     ------------------------------------------------- -----------------
     ``__cpp_lib_has_unique_object_representations``   ``201606L``      
     ------------------------------------------------- -----------------
     ``__cpp_lib_hypot``                               ``201603L``      
     ------------------------------------------------- -----------------
     ``__cpp_lib_incomplete_container_elements``       ``201505L``      
     ------------------------------------------------- -----------------
     ``__cpp_lib_invoke``                              ``201411L``      

libcxx/include/version

 // # define __cpp_lib_boyer_moore_searcher                 201603L
 # define __cpp_lib_byte                                 201603L
 # define __cpp_lib_chrono                               201611L
 # define __cpp_lib_clamp                                201603L
 # define __cpp_lib_enable_shared_from_this              201603L
 // # define __cpp_lib_execution                            201603L
 # define __cpp_lib_filesystem                           201703L
 # define __cpp_lib_gcd_lcm                              201606L
-# define __cpp_lib_hardware_interference_size           201703L
+// # define __cpp_lib_hardware_interference_size           201703L
 # if defined(_LIBCPP_HAS_UNIQUE_OBJECT_REPRESENTATIONS)
 #   define __cpp_lib_has_unique_object_representations  201606L
 # endif
 # define __cpp_lib_hypot                                201603L
 # define __cpp_lib_incomplete_container_elements        201505L
 # define __cpp_lib_invoke                               201411L
 # if !defined(_LIBCPP_HAS_NO_IS_AGGREGATE)
 #   define __cpp_lib_is_aggregate                       201703L

libcxx/test/std/language.support/support.limits/support.limits.general/new.version.pass.cpp

 # endif
 
 #elif TEST_STD_VER == 17
 
 # ifdef __cpp_lib_destroying_delete
 #   error "__cpp_lib_destroying_delete should not be defined before c++2a"
 # endif
 
-# ifndef __cpp_lib_hardware_interference_size
-#   error "__cpp_lib_hardware_interference_size should be defined in c++17"
-# endif
-# if __cpp_lib_hardware_interference_size != 201703L
-#   error "__cpp_lib_hardware_interference_size should have the value 201703L in c++17"
-# endif
+# if !defined(_LIBCPP_VERSION)
+#   ifndef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should be defined in c++17"
+#   endif
+#   if __cpp_lib_hardware_interference_size != 201703L
+#     error "__cpp_lib_hardware_interference_size should have the value 201703L in c++17"
+#   endif
+# else // _LIBCPP_VERSION
+#   ifdef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should not be defined because it is unimplemented in libc++!"
+#   endif
+# endif
 
 # ifndef __cpp_lib_launder
 #   error "__cpp_lib_launder should be defined in c++17"
 # endif
 # if __cpp_lib_launder != 201606L
 #   error "__cpp_lib_launder should have the value 201606L in c++17"
 # endif
 
 #elif TEST_STD_VER > 17
 
 # if TEST_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L
 #   ifndef __cpp_lib_destroying_delete
 #     error "__cpp_lib_destroying_delete should be defined in c++2a"
 #   endif
 #   if __cpp_lib_destroying_delete != 201806L
 #     error "__cpp_lib_destroying_delete should have the value 201806L in c++2a"
 #   endif
 # else
 #   ifdef __cpp_lib_destroying_delete
 #     error "__cpp_lib_destroying_delete should not be defined when TEST_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L is not defined!"
 #   endif
 # endif
 
-# ifndef __cpp_lib_hardware_interference_size
-#   error "__cpp_lib_hardware_interference_size should be defined in c++2a"
-# endif
-# if __cpp_lib_hardware_interference_size != 201703L
-#   error "__cpp_lib_hardware_interference_size should have the value 201703L in c++2a"
-# endif
+# if !defined(_LIBCPP_VERSION)
+#   ifndef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should be defined in c++2a"
+#   endif
+#   if __cpp_lib_hardware_interference_size != 201703L
+#     error "__cpp_lib_hardware_interference_size should have the value 201703L in c++2a"
+#   endif
+# else // _LIBCPP_VERSION
+#   ifdef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should not be defined because it is unimplemented in libc++!"
+#   endif
+# endif
 
 # ifndef __cpp_lib_launder
 #   error "__cpp_lib_launder should be defined in c++2a"
 # endif
 # if __cpp_lib_launder != 201606L
 #   error "__cpp_lib_launder should have the value 201606L in c++2a"
 # endif
 
 #endif // TEST_STD_VER > 17
 
 int main(int, char**) { return 0; }

libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp

 # if __cpp_lib_generic_associative_lookup != 201304L
 #   error "__cpp_lib_generic_associative_lookup should have the value 201304L in c++17"
 # endif
 
 # ifdef __cpp_lib_generic_unordered_lookup
 #   error "__cpp_lib_generic_unordered_lookup should not be defined before c++2a"
 # endif
 
-# ifndef __cpp_lib_hardware_interference_size
-#   error "__cpp_lib_hardware_interference_size should be defined in c++17"
-# endif
-# if __cpp_lib_hardware_interference_size != 201703L
-#   error "__cpp_lib_hardware_interference_size should have the value 201703L in c++17"
-# endif
+# if !defined(_LIBCPP_VERSION)
+#   ifndef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should be defined in c++17"
+#   endif
+#   if __cpp_lib_hardware_interference_size != 201703L
+#     error "__cpp_lib_hardware_interference_size should have the value 201703L in c++17"
+#   endif
+# else // _LIBCPP_VERSION
+#   ifdef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should not be defined because it is unimplemented in libc++!"
+#   endif
+# endif
 
 # if TEST_HAS_BUILTIN_IDENTIFIER(__has_unique_object_representations) || TEST_GCC_VER >= 700
 #   ifndef __cpp_lib_has_unique_object_representations
 #     error "__cpp_lib_has_unique_object_representations should be defined in c++17"
 #   endif
 #   if __cpp_lib_has_unique_object_representations != 201606L
 #     error "__cpp_lib_has_unique_object_representations should have the value 201606L in c++17"
 #   endif

 #     error "__cpp_lib_generic_unordered_lookup should have the value 201811L in c++2a"
 #   endif
 # else // _LIBCPP_VERSION
 #   ifdef __cpp_lib_generic_unordered_lookup
 #     error "__cpp_lib_generic_unordered_lookup should not be defined because it is unimplemented in libc++!"
 #   endif
 # endif
 
-# ifndef __cpp_lib_hardware_interference_size
-#   error "__cpp_lib_hardware_interference_size should be defined in c++2a"
-# endif
-# if __cpp_lib_hardware_interference_size != 201703L
-#   error "__cpp_lib_hardware_interference_size should have the value 201703L in c++2a"
-# endif
+# if !defined(_LIBCPP_VERSION)
+#   ifndef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should be defined in c++2a"
+#   endif
+#   if __cpp_lib_hardware_interference_size != 201703L
+#     error "__cpp_lib_hardware_interference_size should have the value 201703L in c++2a"
+#   endif
+# else // _LIBCPP_VERSION
+#   ifdef __cpp_lib_hardware_interference_size
+#     error "__cpp_lib_hardware_interference_size should not be defined because it is unimplemented in libc++!"
+#   endif
+# endif
 
 # if TEST_HAS_BUILTIN_IDENTIFIER(__has_unique_object_representations) || TEST_GCC_VER >= 700
 #   ifndef __cpp_lib_has_unique_object_representations
 #     error "__cpp_lib_has_unique_object_representations should be defined in c++2a"
 #   endif
 #   if __cpp_lib_has_unique_object_representations != 201606L
 #     error "__cpp_lib_has_unique_object_representations should have the value 201606L in c++2a"
 #   endif

libcxx/utils/generate_feature_test_macro_components.py

feature_test_macros = sorted([ add_version_header(x) for x in [
    },
    "headers": ["cstddef"],
    },
   {"name": "__cpp_lib_hardware_interference_size",
    "values": {
      "c++17": int(201703),
    },
    "headers": ["new"],
+   "unimplemented": True,
    },
   {"name": "__cpp_lib_launder",
    "values": {
      "c++17": int(201606),
    },
    "headers": ["new"],
    },
   {"name": "__cpp_lib_uncaught_exceptions",