This is an archive of the discontinued LLVM Phabricator instance.

Differential D80326

[SVE] Eliminate calls to default-false VectorType::get() from Linker
ClosedPublic

Authored by ctetreau on May 20 2020, 2:52 PM.

Details

Reviewers
efriedma
tejohnson
sdesmalen
c-rhodes
Commits
rG77b1ed4b4a49: [SVE] Eliminate calls to default-false VectorType::get() from Linker

Diff Detail

Event Timeline

ctetreau created this revision.May 20 2020, 2:52 PM
Herald added a reviewer: efriedma. · View Herald TranscriptMay 20 2020, 2:52 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, psnobl, rkruppe and 2 others. · View Herald Transcript
ctetreau added reviewers: tejohnson, sdesmalen, c-rhodes.May 20 2020, 2:54 PM
efriedma added inline comments.May 20 2020, 3:24 PM
llvm/lib/Linker/IRMover.cpp
312

While you're here, please change the cast<> to cast<FixedVectorType>(Ty).

Harbormaster completed remote builds in B57437: Diff 265352.May 20 2020, 4:34 PM
ctetreau added a child revision: D80342: [SVE] Deprecate default false variant of VectorType::get.May 20 2020, 4:36 PM
ctetreau marked an inline comment as done.May 20 2020, 5:08 PM
ctetreau added inline comments.
llvm/lib/Linker/IRMover.cpp
312

I actually skipped that on purpose to keep the patch small. Knowing my luck, this would cause a test failure.

I can make the change.

ctetreau updated this revision to Diff 265544.May 21 2020, 10:55 AM

address code review issues

efriedma accepted this revision.May 21 2020, 12:49 PM

LGTM

This revision is now accepted and ready to land.May 21 2020, 12:49 PM
Harbormaster completed remote builds in B57552: Diff 265544.May 21 2020, 12:59 PM
ctetreau updated this revision to Diff 267006.May 28 2020, 12:59 PM

rebase

Harbormaster completed remote builds in B58303: Diff 267006.May 28 2020, 6:11 PM
Closed by commit rG77b1ed4b4a49: [SVE] Eliminate calls to default-false VectorType::get() from Linker (authored by ctetreau). · Explain WhyMay 29 2020, 6:02 PM
This revision was automatically updated to reflect the committed changes.
ctetreau removed a child revision: D80342: [SVE] Deprecate default false variant of VectorType::get.Jun 9 2020, 2:13 PM

Revision Contents

PathSize
llvm/
lib/
Linker/
7 lines

Diff 267422

llvm/lib/Linker/IRMover.cpp

Show First 20 Lines • Show All 299 Lines • ▼ Show 20 Lines#endif
// Otherwise, rebuild a modified type. // Otherwise, rebuild a modified type.
switch (Ty->getTypeID()) { switch (Ty->getTypeID()) {
default: default:
llvm_unreachable("unknown derived type to remap"); llvm_unreachable("unknown derived type to remap");
case Type::ArrayTyID: case Type::ArrayTyID:
return *Entry = ArrayType::get(ElementTypes[0], return *Entry = ArrayType::get(ElementTypes[0],
cast<ArrayType>(Ty)->getNumElements()); cast<ArrayType>(Ty)->getNumElements());
case Type::FixedVectorTyID:
case Type::ScalableVectorTyID: case Type::ScalableVectorTyID:
return *Entry = VectorType::get(ElementTypes[0], // FIXME: handle scalable vectors
cast<VectorType>(Ty)->getNumElements()); case Type::FixedVectorTyID:
return *Entry = FixedVectorType::get(
ElementTypes[0], cast<FixedVectorType>(Ty)->getNumElements());
efriedmaUnsubmitted
Not Done
ReplyInline Actions

While you're here, please change the cast<> to cast<FixedVectorType>(Ty).

efriedma: While you're here, please change the `cast<>` to `cast<FixedVectorType>(Ty)`.
ctetreauAuthorUnsubmitted
Done
ReplyInline Actions

I actually skipped that on purpose to keep the patch small. Knowing my luck, this would cause a test failure.

I can make the change.

ctetreau: I actually skipped that on purpose to keep the patch small. Knowing my luck, this would cause a…
case Type::PointerTyID: case Type::PointerTyID:
return *Entry = PointerType::get(ElementTypes[0], return *Entry = PointerType::get(ElementTypes[0],
cast<PointerType>(Ty)->getAddressSpace()); cast<PointerType>(Ty)->getAddressSpace());
case Type::FunctionTyID: case Type::FunctionTyID:
return *Entry = FunctionType::get(ElementTypes[0], return *Entry = FunctionType::get(ElementTypes[0],
makeArrayRef(ElementTypes).slice(1), makeArrayRef(ElementTypes).slice(1),
cast<FunctionType>(Ty)->isVarArg()); cast<FunctionType>(Ty)->isVarArg());
case Type::StructTyID: { case Type::StructTyID: {
▲ Show 20 Lines • Show All 1,274 Lines • Show Last 20 Lines