Page MenuHomePhabricator

[SVE] Eliminate calls to default-false VectorType::get() from Linker
ClosedPublic

Authored by ctetreau on May 20 2020, 2:52 PM.

Diff Detail

Event Timeline

ctetreau created this revision.May 20 2020, 2:52 PM
Herald added a project: Restricted Project. · View Herald Transcript
efriedma added inline comments.May 20 2020, 3:24 PM
llvm/lib/Linker/IRMover.cpp
312

While you're here, please change the cast<> to cast<FixedVectorType>(Ty).

ctetreau marked an inline comment as done.May 20 2020, 5:08 PM
ctetreau added inline comments.
llvm/lib/Linker/IRMover.cpp
312

I actually skipped that on purpose to keep the patch small. Knowing my luck, this would cause a test failure.

I can make the change.

ctetreau updated this revision to Diff 265544.May 21 2020, 10:55 AM

address code review issues

This revision is now accepted and ready to land.May 21 2020, 12:49 PM
This revision was automatically updated to reflect the committed changes.