Encountered the following situation: Let we started thread T1 and it hit breakpoint on B1 location. We suspended T1 and continued the process. Then we started thread T2 which hit for example the same location B1. This time in a breakpoint callback we decided not to stop returning false.
Expected result: process continues (as if T2 did not hit breakpoint) its workflow with T1 still suspended.
Actual result: process do stops (as if T2 callback returned true).
Solution: We need invalidate StopInfo for threads that was previously suspended just because something that is already inactive can not be the reason of stop. Thread::GetPrivateStopInfo() may be appropriate place to do it, because it gets called (through Thread::GetStopInfo()) every time before process reports stop and user gets chance to change m_resume_state again i.e if we see m_resume_state == eStateSuspended it definitely means it was set during previous stop and it also means this thread can not be stopped again (cos' it was frozen during previous stop).
I would use a reference for have_valid_stopinfo_ptr here. Passing this in isn't optional (and you don't check if the pointer is null...) which is better expressed by taking a reference. If you do have a reason why you want this to be a pointer, then you need to check if its non-null before setting it.
Also, I think "found_valid_stopinfo" is a better name. "have" makes it sound like you are asking whether the ProcessEventData has a valid stopinfo pointer, which doesn't really make sense since Events don't have stop info.
What you are saying is the should stop computation found one...