Page MenuHomePhabricator

[MLIR] Fix linkage for libMLIR.so
ClosedPublic

Authored by stephenneuendorffer on May 16 2020, 11:04 PM.

Details

Summary

Generally:

  1. don't use target_link_libraries() and add_mlir_library() on the same target, use LINK_LIBS PUBLIC instead.
  2. don't use LINK_LIBS to specify LLVM libraries. Use LINK_COMPONENTS instead
  3. no need to link against LLVMSupport. We pull it in by default.

Depends on D80075

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 17 2020, 2:23 PM
This revision was automatically updated to reflect the committed changes.