This is an archive of the discontinued LLVM Phabricator instance.

Differential D80035

[MLIR] LinalgToStandard: use LINK_LIBS rather than target_link_libraries.
ClosedPublic

Authored by stephenneuendorffer on May 15 2020, 2:24 PM.

Details

Reviewers
nicolasvasilache
Commits
rG1cff8e8de79f: [MLIR] LinalgToStandard: use LINK_LIBS rather than target_link_libraries.
Summary

Also, missing MLIRTransforms as a dependency. This breaks BUILD_SHARED_LIBS=on

Diff Detail

Event Timeline

stephenneuendorffer created this revision.May 15 2020, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2020, 2:24 PM
Herald added subscribers: llvm-commits, jurahul, Kayjukh and 15 others. · View Herald Transcript
stephenneuendorffer added a reviewer: nicolasvasilache.May 15 2020, 2:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 2:42 PM
Closed by commit rG1cff8e8de79f: [MLIR] LinalgToStandard: use LINK_LIBS rather than target_link_libraries. (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B56916: Diff 264342!May 15 2020, 3:14 PM

Revision Contents

PathSize
mlir/
lib/
Conversion/
LinalgToStandard/
5 lines

Diff 264342

mlir/lib/Conversion/LinalgToStandard/CMakeLists.txt

add_mlir_conversion_library(MLIRLinalgToStandard add_mlir_conversion_library(MLIRLinalgToStandard
LinalgToStandard.cpp LinalgToStandard.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToStandard ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToStandard
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
)
target_link_libraries(MLIRLinalgToStandard LINK_LIBS PUBLIC
PUBLIC
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRPass MLIRPass
MLIRSCF MLIRSCF
MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )