This is an archive of the discontinued LLVM Phabricator instance.

Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)
AbandonedPublic

Authored by dang on May 15 2020, 5:21 AM.

Details

Reviewers
Bigcheese
Summary

This lets users of PCM get a clean hash of the AST for uniquing based
on that. This required looking up implicit modules in the module offset map to
be looked up by name instead of by file path.

The previous patch is at D79993.
The next patch is at D80003.

Diff Detail

Event Timeline

dang created this revision.May 15 2020, 5:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2020, 5:21 AM
dang added a comment.May 15 2020, 6:04 AM

Should I add the test here or in the clang-scan-deps patch?

dang edited the summary of this revision. (Show Details)May 15 2020, 6:31 AM

Should I add the test here or in the clang-scan-deps patch?

It's best to have a test in every non-nfc patch. You should be able to test this with llvm-bcanalyzer.

dang updated this revision to Diff 265262.May 20 2020, 8:29 AM

Add a small bug fix and test case

dang updated this revision to Diff 265263.EditedMay 20 2020, 8:31 AM

Uploaded the wrong diff

dang abandoned this revision.May 21 2020, 9:20 AM

This revision is superseded by D80383