This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Modernize analyzer's Python scripts
ClosedPublic

Authored by vsavchenko on May 14 2020, 3:34 AM.

Details

Summary

Fix read/write in binary format, which crashes Python 3.
Additionally, clean up redundant (as for Python 3) code and
fix a handful of flake8 warnings.

Diff Detail

Unit TestsFailed

Event Timeline

vsavchenko created this revision.May 14 2020, 3:34 AM

Add more 'super' clean-ups

NoQ accepted this revision.May 14 2020, 5:07 AM

Thanks!!

Note that there are no tests for these scripts. It's probably not too bad because these scripts *are* the tests but we might as well benefit from some quicker LIT tests that'll respond to our mistakes faster than buildbot re-runs.

This revision is now accepted and ready to land.May 14 2020, 5:07 AM
This revision was automatically updated to reflect the committed changes.