This is an archive of the discontinued LLVM Phabricator instance.

Differential D79889

[MLIR] Discourage people from copying the toy examples
ClosedPublic

Authored by stephenneuendorffer on May 13 2020, 10:36 AM.

Details

Reviewers
None
Commits
rGd02fce2d149e: [MLIR] Discourage people from copying the toy examples
Summary

The CMake structure of the toy example is non-standard. encourage people to
copy the standalone example instead.

Depends on D79841

Diff Detail

Event Timeline

stephenneuendorffer created this revision.May 13 2020, 10:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2020, 10:36 AM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 14 others. · View Herald Transcript
stephenneuendorffer added a child revision: D79890: [MLIR] Continue renaming of "SideEffects".May 13 2020, 10:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 13 2020, 10:52 AM
Closed by commit rGd02fce2d149e: [MLIR] Discourage people from copying the toy examples (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
bondhugula added a subscriber: bondhugula.May 13 2020, 11:19 AM
bondhugula added inline comments.
mlir/examples/toy/Ch1/CMakeLists.txt
1

Nit: missing period at the end, and for the ones below.

Harbormaster failed remote builds in B56627: Diff 263778!May 13 2020, 11:25 AM

Revision Contents

PathSize
mlir/
examples/
toy/
Ch1/
1 line
Ch2/
1 line
Ch3/
1 line
Ch4/
1 line
include/
toy/
2 lines
Ch5/
1 line
include/
toy/
2 lines
Ch6/
1 line
include/
toy/
2 lines
Ch7/
1 line
include/
toy/
2 lines

Diff 263788

mlir/examples/toy/Ch1/CMakeLists.txt

# For a better template to copy, see examples/standalone
bondhugulaUnsubmitted
Not Done
ReplyInline Actions

Nit: missing period at the end, and for the ones below.

bondhugula: Nit: missing period at the end, and for the ones below.
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_toy_chapter(toyc-ch1 add_toy_chapter(toyc-ch1
toyc.cpp toyc.cpp
parser/AST.cpp parser/AST.cpp
) )
include_directories(include/) include_directories(include/)
target_link_libraries(toyc-ch1 target_link_libraries(toyc-ch1
PRIVATE PRIVATE
MLIRSupport) MLIRSupport)

mlir/examples/toy/Ch2/CMakeLists.txt

# For a better template to copy, see examples/standalone
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_toy_chapter(toyc-ch2 add_toy_chapter(toyc-ch2
toyc.cpp toyc.cpp
Show All 17 Lines

mlir/examples/toy/Ch3/CMakeLists.txt

# For a better template to copy, see examples/standalone
include_directories(include) include_directories(include)
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td) set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td)
Show All 26 Lines

mlir/examples/toy/Ch4/CMakeLists.txt

# For a better template to copy, see examples/standalone
include_directories(include) include_directories(include)
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td) set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td)
Show All 29 Lines

mlir/examples/toy/Ch4/include/toy/CMakeLists.txt

# Most dialects should use add_mlir_dialect(). See examples/standalone.
set(LLVM_TARGET_DEFINITIONS Ops.td) set(LLVM_TARGET_DEFINITIONS Ops.td)
mlir_tablegen(Ops.h.inc -gen-op-decls) mlir_tablegen(Ops.h.inc -gen-op-decls)
mlir_tablegen(Ops.cpp.inc -gen-op-defs) mlir_tablegen(Ops.cpp.inc -gen-op-defs)
add_public_tablegen_target(ToyCh4OpsIncGen) add_public_tablegen_target(ToyCh4OpsIncGen)
# Most dialects should use add_mlir_interfaces().
set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td) set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td)
mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls) mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls)
mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs) mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(ToyCh4ShapeInferenceInterfaceIncGen) add_public_tablegen_target(ToyCh4ShapeInferenceInterfaceIncGen)

mlir/examples/toy/Ch5/CMakeLists.txt

# For a better template to copy, see examples/standalone
include_directories(include) include_directories(include)
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td) set(LLVM_TARGET_DEFINITIONS mlir/ToyCombine.td)
Show All 32 Lines

mlir/examples/toy/Ch5/include/toy/CMakeLists.txt

# Most dialects should use add_mlir_dialect(). See examples/standalone.
set(LLVM_TARGET_DEFINITIONS Ops.td) set(LLVM_TARGET_DEFINITIONS Ops.td)
mlir_tablegen(Ops.h.inc -gen-op-decls) mlir_tablegen(Ops.h.inc -gen-op-decls)
mlir_tablegen(Ops.cpp.inc -gen-op-defs) mlir_tablegen(Ops.cpp.inc -gen-op-defs)
add_public_tablegen_target(ToyCh5OpsIncGen) add_public_tablegen_target(ToyCh5OpsIncGen)
# Most dialects should use add_mlir_interfaces().
set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td) set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td)
mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls) mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls)
mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs) mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(ToyCh5ShapeInferenceInterfaceIncGen) add_public_tablegen_target(ToyCh5ShapeInferenceInterfaceIncGen)

mlir/examples/toy/Ch6/CMakeLists.txt

# For a better template to copy, see examples/standalone
include_directories(include) include_directories(include)
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
Support Support
nativecodegen nativecodegen
OrcJIT OrcJIT
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

mlir/examples/toy/Ch6/include/toy/CMakeLists.txt

# Most dialects should use add_mlir_dialect(). See examples/standalone.
set(LLVM_TARGET_DEFINITIONS Ops.td) set(LLVM_TARGET_DEFINITIONS Ops.td)
mlir_tablegen(Ops.h.inc -gen-op-decls) mlir_tablegen(Ops.h.inc -gen-op-decls)
mlir_tablegen(Ops.cpp.inc -gen-op-defs) mlir_tablegen(Ops.cpp.inc -gen-op-defs)
add_public_tablegen_target(ToyCh6OpsIncGen) add_public_tablegen_target(ToyCh6OpsIncGen)
# Most dialects should use add_mlir_interfaces().
set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td) set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td)
mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls) mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls)
mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs) mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(ToyCh6ShapeInferenceInterfaceIncGen) add_public_tablegen_target(ToyCh6ShapeInferenceInterfaceIncGen)

mlir/examples/toy/Ch7/CMakeLists.txt

# For a better template to copy, see examples/standalone
include_directories(include) include_directories(include)
add_subdirectory(include) add_subdirectory(include)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
Support Support
nativecodegen nativecodegen
OrcJIT OrcJIT
Show All 40 Lines

mlir/examples/toy/Ch7/include/toy/CMakeLists.txt

# Most dialects should use add_mlir_dialect(). See examples/standalone.
set(LLVM_TARGET_DEFINITIONS Ops.td) set(LLVM_TARGET_DEFINITIONS Ops.td)
mlir_tablegen(Ops.h.inc -gen-op-decls) mlir_tablegen(Ops.h.inc -gen-op-decls)
mlir_tablegen(Ops.cpp.inc -gen-op-defs) mlir_tablegen(Ops.cpp.inc -gen-op-defs)
add_public_tablegen_target(ToyCh7OpsIncGen) add_public_tablegen_target(ToyCh7OpsIncGen)
# Most dialects should use add_mlir_interfaces().
set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td) set(LLVM_TARGET_DEFINITIONS ShapeInferenceInterface.td)
mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls) mlir_tablegen(ShapeInferenceOpInterfaces.h.inc -gen-op-interface-decls)
mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs) mlir_tablegen(ShapeInferenceOpInterfaces.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(ToyCh7ShapeInferenceInterfaceIncGen) add_public_tablegen_target(ToyCh7ShapeInferenceInterfaceIncGen)