Page MenuHomePhabricator

[mlir][shape] Tidy up shape.shape_of
ClosedPublic

Authored by silvas on May 9 2020, 7:19 PM.

Details

Summary
  • Mark it NoSideEffect
  • Add custom parser/printer

Diff Detail

Event Timeline

silvas created this revision.May 9 2020, 7:19 PM
Herald added a project: Restricted Project. · View Herald Transcript
jpienaar accepted this revision.May 10 2020, 1:16 PM
jpienaar marked an inline comment as done.

LG, thanks

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
235

So this matches the style of cmpi as the result type is always known?

This revision is now accepted and ready to land.May 10 2020, 1:16 PM
This revision was automatically updated to reflect the committed changes.