Page MenuHomePhabricator

[Attributor] Fix for a crash on RAUW when rewriting function signature
ClosedPublic

Authored by sdmitriev on May 9 2020, 4:45 PM.

Diff Detail

Event Timeline

sdmitriev created this revision.May 9 2020, 4:45 PM
Herald added a reviewer: uenoku. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
uenoku accepted this revision.May 10 2020, 9:57 AM

Looks reasonable to me.

This revision is now accepted and ready to land.May 10 2020, 9:57 AM
This revision was automatically updated to reflect the committed changes.

The fix is somewhat counter intuitive or I do not understand it. Checking if we have uses before replacing *all uses* seems redundant. I guess the different type was the problem, question is if we need the RAUW at all and if so, if the type might be different in other situations.