Some testcases are unexpectedly passing with NPM.
This is because the target functions are inlined in NPM.
I think we should add noinline attribute to keep these test points.
Differential D79648
[compiler-rt][asan] Add noinline to use-after-scope testcases jsji on May 8 2020, 1:38 PM. Authored by
Details Some testcases are unexpectedly passing with NPM. I think we should add noinline attribute to keep these test points.
Diff Detail
Event TimelineComment Actions I think we should avoid adding duplicates of compiler-rt test for new PM and add COMPILER_RT_TEST_USE_NEWPM like this one: Comment Actions Agree! Removed RUN lines in this patch. I will try COMPILER_RT_TEST_USE_NEWPM and COMPILER_RT_TEST_COMPILER_CFLAGS. Do we want to force running both PM by default? I think maybe the later is better, but just to double confirm. Comment Actions As default we should keep what ever is in LLVM default.
yes. we can add few new steps e.g. here: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux
Comment Actions
Had a quick look, looks like we won't pass down COMPILER_RT_TEST_COMPILER_CFLAGS from clang/llvm for now. But I think we can build and test standalone compile_rt by adding two steps:
What do you think? |