[compiler-rt][asan] Add noinline to use-after-scope testcases

[jsji]

Summary

Some testcases are unexpectedly passing with NPM.
This is because the target functions are inlined in NPM.

I think we should add noinline attribute to keep these test points.

[vitalybuka]

I think we should avoid adding duplicates of compiler-rt test for new PM and add COMPILER_RT_TEST_USE_NEWPM like this one:
https://github.com/llvm/llvm-project/blob/68a9356bdea69dbcec1233f8b1fab47e72fca991/compiler-rt/test/lit.common.cfg.py#L456
to run all tests both ways

[vitalybuka]

also there is COMPILER_RT_TEST_COMPILER_CFLAGS which is probably enough

[jsji]

Remove RUN lines

[jsji]

In D79648#2028042, @vitalybuka wrote:

I think we should avoid adding duplicates of compiler-rt test for new PM and add COMPILER_RT_TEST_USE_NEWPM like this one:
https://github.com/llvm/llvm-project/blob/68a9356bdea69dbcec1233f8b1fab47e72fca991/compiler-rt/test/lit.common.cfg.py#L456
to run all tests both ways

Agree! Removed RUN lines in this patch. I will try COMPILER_RT_TEST_USE_NEWPM and COMPILER_RT_TEST_COMPILER_CFLAGS.

Do we want to force running both PM by default?
Or we can just add NEWPM run in one of the buildbot?

I think maybe the later is better, but just to double confirm.

[vitalybuka]

In D79648#2028485, @jsji wrote:

In D79648#2028042, @vitalybuka wrote:

I think we should avoid adding duplicates of compiler-rt test for new PM and add COMPILER_RT_TEST_USE_NEWPM like this one:
https://github.com/llvm/llvm-project/blob/68a9356bdea69dbcec1233f8b1fab47e72fca991/compiler-rt/test/lit.common.cfg.py#L456
to run all tests both ways

Agree! Removed RUN lines in this patch. I will try COMPILER_RT_TEST_USE_NEWPM and COMPILER_RT_TEST_COMPILER_CFLAGS.

Do we want to force running both PM by default?

As default we should keep what ever is in LLVM default.

Or we can just add NEWPM run in one of the buildbot?

yes. we can add few new steps e.g. here: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux

I think maybe the later is better, but just to double confirm.

[jsji]

yes. we can add few new steps e.g. here: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux

Had a quick look, looks like we won't pass down COMPILER_RT_TEST_COMPILER_CFLAGS from clang/llvm for now.

But I think we can build and test standalone compile_rt by adding two steps:

1. build standalone compiler-rt with npm by adding COMPILER_RT_TEST_COMPILER_CFLAGS
2. test standalone compiler-rt with npm

What do you think?

compiler-rt/test/asan/TestCases/use-after-scope-dtor-order.cpp

 // RUN: %clangxx_asan -O1 -fsanitize-address-use-after-scope %s -o %t && \
 // RUN:     not %run %t 2>&1 | FileCheck %s
 
 #include <stdio.h>
 
 struct IntHolder {
   explicit IntHolder(int *val = 0) : val_(val) { }
-  ~IntHolder() {
+  __attribute__((noinline)) ~IntHolder() {
     printf("Value: %d\n", *val_);  // BOOM
     // CHECK: ERROR: AddressSanitizer: stack-use-after-scope
     // CHECK:  #0 0x{{.*}} in IntHolder::~IntHolder{{.*}}.cpp:[[@LINE-2]]
   }
   void set(int *val) { val_ = val; }
   int *get() { return val_; }
 
   int *val_;

compiler-rt/test/asan/TestCases/use-after-scope-temp.cpp

 // RUN: %clangxx_asan %stdcxx11 -O1 -fsanitize-address-use-after-scope %s -o %t && \
 // RUN:     not %run %t 2>&1 | FileCheck %s
 
 
 struct IntHolder {
   int val;
 };
 
 const IntHolder *saved;
 
-void save(const IntHolder &holder) {
+__attribute__((noinline)) void save(const IntHolder &holder) {
   saved = &holder;
 }
 
 int main(int argc, char *argv[]) {
   save({argc});
   int x = saved->val;  // BOOM
   // CHECK: ERROR: AddressSanitizer: stack-use-after-scope
   // CHECK:  #0 0x{{.*}} in main {{.*}}use-after-scope-temp.cpp:[[@LINE-2]]
   return x;
 }

compiler-rt/test/asan/TestCases/use-after-scope-temp2.cpp

 // RUN: %clangxx_asan %stdcxx11 -O1 -fsanitize-address-use-after-scope %s -o %t && \
 // RUN:     not %run %t 2>&1 | FileCheck %s
 
 
 struct IntHolder {
-  const IntHolder& Self() const {
+  __attribute__((noinline)) const IntHolder &Self() const {
     return *this;
   }
   int val = 3;
 };
 
 const IntHolder *saved;
 
 int main(int argc, char *argv[]) {
   saved = &IntHolder().Self();
   int x = saved->val;  // BOOM
   // CHECK: ERROR: AddressSanitizer: stack-use-after-scope
   // CHECK:  #0 0x{{.*}} in main {{.*}}use-after-scope-temp2.cpp:[[@LINE-2]]
   return x;
 }