Page MenuHomePhabricator

Fix MSan test use-after-dtor.cpp under new pass manager
ClosedPublic

Authored by aeubanks on Thu, May 7, 12:27 PM.

Details

Summary

The new pass manager symbolizes the location as ~Simple instead of Simple::~Simple.

Diff Detail

Event Timeline

aeubanks created this revision.Thu, May 7, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 7, 12:27 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

rnk@ mentioned to me something about inlining and symbolization under the new pass manager, any links to that so I can put it in the description?

vitalybuka accepted this revision.Thu, May 7, 12:38 PM
This revision is now accepted and ready to land.Thu, May 7, 12:38 PM
This revision was automatically updated to reflect the committed changes.
rnk added a subscriber: probinson.Wed, May 13, 8:28 AM

rnk@ mentioned to me something about inlining and symbolization under the new pass manager, any links to that so I can put it in the description?

BTW I did go digging through the test case to find prior discussions of this issue, but didn't find anything concrete. You can try experimenting by compiling small toy programs locally with -fsanitize=address -gline-tables-only, and controlling the inlining with always_inline / noinline to nail down exactly what the behavior is.

I thought there was a past effort to emit linkage names on all DW_TAG_subprograms emitted under gmlt to improve stack traces in these situations. Maybe @probinson remembers this discussion.