This is an archive of the discontinued LLVM Phabricator instance.

Differential D79577

[mlir][vulkan-runner] Remove duplicated/uncessary link libraries
ClosedPublic

Authored by antiagainst on May 7 2020, 7:36 AM.

Details

Reviewers
denis13
Commits
rGc2414c20397a: [mlir][vulkan-runner] Remove duplicated/uncessary link libraries
Summary

vulkan-runtime-wrappers does not need MLIRSPIRVSerialization,
which is used by the ConvertGpuLaunchFuncToVulkanLaunchFunc pass
under the hood.

Diff Detail

Event Timeline

antiagainst created this revision.May 7 2020, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2020, 7:36 AM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 14 others. · View Herald Transcript
Harbormaster failed remote builds in B56067: Diff 262648!May 7 2020, 8:29 AM
denis13 accepted this revision.May 7 2020, 9:23 AM

Thanks! It fixes a build problem!

This revision is now accepted and ready to land.May 7 2020, 9:23 AM
antiagainst added a comment.May 7 2020, 10:58 AM
In D79577#2025283, @denis13 wrote:

Thanks! It fixes a build problem!

Yup. I still have the action item to enable Vulkan tests on MLIR buildbots. Need to get to it. :)

Closed by commit rGc2414c20397a: [mlir][vulkan-runner] Remove duplicated/uncessary link libraries (authored by antiagainst). · Explain WhyMay 7 2020, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-vulkan-runner/
4 lines

Diff 262701

mlir/tools/mlir-vulkan-runner/CMakeLists.txt

Show All 39 Linesif (MLIR_VULKAN_RUNNER_ENABLED)
target_include_directories(vulkan-runtime-wrappers target_include_directories(vulkan-runtime-wrappers
PRIVATE ${Vulkan_INCLUDE_DIR} PRIVATE ${Vulkan_INCLUDE_DIR}
LLVMSupport LLVMSupport
) )
target_link_libraries(vulkan-runtime-wrappers target_link_libraries(vulkan-runtime-wrappers
PUBLIC PUBLIC
LLVMSupport
MLIRSPIRVSerialization
LLVMCore LLVMCore
LLVMSupport LLVMSupport
${Vulkan_LIBRARY} ${Vulkan_LIBRARY}
) )
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS) get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
set(LIBS set(LIBS
${dialect_libs} ${dialect_libs}
${conversion_libs} ${conversion_libs}
LLVMCore LLVMCore
LLVMSupport LLVMSupport
MLIRJitRunner
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRExecutionEngine MLIRExecutionEngine
MLIRIR MLIRIR
MLIRJitRunner
MLIRLLVMIR MLIRLLVMIR
MLIRParser MLIRParser
MLIRSPIRVTransforms MLIRSPIRVTransforms
MLIRSupport MLIRSupport
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTransforms MLIRTransforms
MLIRTranslation MLIRTranslation
${Vulkan_LIBRARY} ${Vulkan_LIBRARY}
Show All 21 Lines