This is an archive of the discontinued LLVM Phabricator instance.

[NFC][DebugInfo][DWARF] Add test for variables with a single location which doesn't span their entire scope.
ClosedPublic

Authored by Orlando on May 7 2020, 6:43 AM.

Details

Summary

While working on D79571 I noticed I could change parts of validThroughout
without causing any test failures (*). I'll try to come up with some more tests
if I continue working in this area.

(*) llvm/test/DebugInfo/MIR/AArch64/implicit-def-dead-scope.mir may
fail under similar conditions as one of the checks here, but I don't think it
will catch them both.

Diff Detail

Event Timeline

Orlando created this revision.May 7 2020, 6:43 AM
aprantl accepted this revision.May 7 2020, 10:00 AM
aprantl added inline comments.
llvm/test/DebugInfo/X86/location-range.mir
111

you don't have to, but you can probably collapse all DILocations in the same scope to one location.

This revision is now accepted and ready to land.May 7 2020, 10:00 AM
vsk accepted this revision.May 7 2020, 11:05 AM
Orlando marked an inline comment as done.May 11 2020, 1:48 AM

Thanks, landing shortly.

llvm/test/DebugInfo/X86/location-range.mir
111

No problem, I did this before committing.

This revision was automatically updated to reflect the committed changes.