This is an archive of the discontinued LLVM Phabricator instance.

Differential D79534

[clang][WebAssembly] Only expose wait and notify builtins with atomics
ClosedPublic

Authored by tlively on May 6 2020, 5:54 PM.

Details

Reviewers
aheejin
sunfish
sbc100
Commits
rGebb69b8bafad: [clang][WebAssembly] Only expose wait and notify builtins with atomics
Summary

Since the underlying wait and notify instructions are only available
when the atomics feature is enabled, it only makes sense to expose
their builtin functions when atomics are enabled.

Diff Detail

Event Timeline

tlively created this revision.May 6 2020, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2020, 5:54 PM
Herald added subscribers: cfe-commits, jfb, jgravelle-google and 2 others. · View Herald Transcript
sbc100 accepted this revision.EditedMay 6 2020, 6:18 PM
This comment has been deleted.
This revision is now accepted and ready to land.May 6 2020, 6:18 PM
Harbormaster failed remote builds in B55999: Diff 262512!May 6 2020, 7:20 PM
aheejin accepted this revision.May 6 2020, 8:29 PM
Closed by commit rGebb69b8bafad: [clang][WebAssembly] Only expose wait and notify builtins with atomics (authored by tlively). · Explain WhyMay 8 2020, 1:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
6 lines
test/
CodeGen/
6 lines

Diff 262952

clang/include/clang/Basic/BuiltinsWebAssembly.def

Show All 39 Lines
BUILTIN(__builtin_wasm_min_f64, "ddd", "nc") BUILTIN(__builtin_wasm_min_f64, "ddd", "nc")
BUILTIN(__builtin_wasm_max_f64, "ddd", "nc") BUILTIN(__builtin_wasm_max_f64, "ddd", "nc")
// Exception handling builtins. // Exception handling builtins.
TARGET_BUILTIN(__builtin_wasm_throw, "vIUiv*", "r", "exception-handling") TARGET_BUILTIN(__builtin_wasm_throw, "vIUiv*", "r", "exception-handling")
TARGET_BUILTIN(__builtin_wasm_rethrow_in_catch, "v", "r", "exception-handling") TARGET_BUILTIN(__builtin_wasm_rethrow_in_catch, "v", "r", "exception-handling")
// Atomic wait and notify. // Atomic wait and notify.
BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n") TARGET_BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n", "atomics")
BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n") TARGET_BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n", "atomics")
BUILTIN(__builtin_wasm_atomic_notify, "Uii*Ui", "n") TARGET_BUILTIN(__builtin_wasm_atomic_notify, "Uii*Ui", "n", "atomics")
// Trapping fp-to-int conversions // Trapping fp-to-int conversions
BUILTIN(__builtin_wasm_trunc_s_i32_f32, "if", "nc") BUILTIN(__builtin_wasm_trunc_s_i32_f32, "if", "nc")
BUILTIN(__builtin_wasm_trunc_u_i32_f32, "if", "nc") BUILTIN(__builtin_wasm_trunc_u_i32_f32, "if", "nc")
BUILTIN(__builtin_wasm_trunc_s_i32_f64, "id", "nc") BUILTIN(__builtin_wasm_trunc_s_i32_f64, "id", "nc")
BUILTIN(__builtin_wasm_trunc_u_i32_f64, "id", "nc") BUILTIN(__builtin_wasm_trunc_u_i32_f64, "id", "nc")
BUILTIN(__builtin_wasm_trunc_s_i64_f32, "LLif", "nc") BUILTIN(__builtin_wasm_trunc_s_i64_f32, "LLif", "nc")
BUILTIN(__builtin_wasm_trunc_u_i64_f32, "LLif", "nc") BUILTIN(__builtin_wasm_trunc_u_i64_f32, "LLif", "nc")
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines

clang/test/CodeGen/builtins-wasm.c

// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +unimplemented-simd128 -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -flax-vector-conversions=none -O3 -emit-llvm -o - %s | FileCheck %s -check-prefixes WEBASSEMBLY,WEBASSEMBLY32 // RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +unimplemented-simd128 -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -target-feature +atomics -flax-vector-conversions=none -O3 -emit-llvm -o - %s | FileCheck %s -check-prefixes WEBASSEMBLY,WEBASSEMBLY32
// RUN: %clang_cc1 -triple wasm64-unknown-unknown -target-feature +unimplemented-simd128 -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -flax-vector-conversions=none -O3 -emit-llvm -o - %s | FileCheck %s -check-prefixes WEBASSEMBLY,WEBASSEMBLY64 // RUN: %clang_cc1 -triple wasm64-unknown-unknown -target-feature +unimplemented-simd128 -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -target-feature +atomics -flax-vector-conversions=none -O3 -emit-llvm -o - %s | FileCheck %s -check-prefixes WEBASSEMBLY,WEBASSEMBLY64
// RUN: not %clang_cc1 -triple wasm64-unknown-unknown -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -flax-vector-conversions=none -O3 -emit-llvm -o - %s 2>&1 | FileCheck %s -check-prefixes MISSING-SIMD // RUN: not %clang_cc1 -triple wasm64-unknown-unknown -target-feature +nontrapping-fptoint -target-feature +exception-handling -target-feature +bulk-memory -target-feature +atomics -flax-vector-conversions=none -O3 -emit-llvm -o - %s 2>&1 | FileCheck %s -check-prefixes MISSING-SIMD
// SIMD convenience types // SIMD convenience types
typedef char i8x16 __attribute((vector_size(16))); typedef char i8x16 __attribute((vector_size(16)));
typedef short i16x8 __attribute((vector_size(16))); typedef short i16x8 __attribute((vector_size(16)));
typedef int i32x4 __attribute((vector_size(16))); typedef int i32x4 __attribute((vector_size(16)));
typedef long long i64x2 __attribute((vector_size(16))); typedef long long i64x2 __attribute((vector_size(16)));
typedef unsigned char u8x16 __attribute((vector_size(16))); typedef unsigned char u8x16 __attribute((vector_size(16)));
typedef unsigned short u16x8 __attribute((vector_size(16))); typedef unsigned short u16x8 __attribute((vector_size(16)));
▲ Show 20 Lines • Show All 717 Lines • Show Last 20 Lines