This is an archive of the discontinued LLVM Phabricator instance.

[lldb/Test] Run dotest.py with the Python LLDB was built with
ClosedPublic

Authored by JDevlieghere on May 6 2020, 2:05 PM.

Details

Summary

The Python used to run lit can be different from the Python LLDB was build with. One scenario where this happens is when LLVM can find the Python 3 interpreter, but not the Python 3 libraries, in which case LLDB build and links against Python 3. Without this change, you end up with an ModuleNotFoundError because of the mismatch.

Instead of looking at the Python interpreter that's used to run lit, we should use the interpreter that matches the Python version LLDB was build against.

Diff Detail

Event Timeline

JDevlieghere created this revision.May 6 2020, 2:05 PM
mib accepted this revision.May 6 2020, 2:16 PM

LGTM!

This revision is now accepted and ready to land.May 6 2020, 2:16 PM
aprantl accepted this revision.May 6 2020, 2:32 PM

That makes sense to me. Thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2020, 3:20 PM