This is an archive of the discontinued LLVM Phabricator instance.

Add MSVC natvis visualisation of llvm::Type
ClosedPublic

Authored by mvhooren on May 4 2020, 8:07 AM.

Download Raw Diff

Details

Reviewers

mspertus
zturner
aaron.ballman

Summary

llvm::Type has some difficult to decode member variables with different meanings depending on the TypeID. Specifically SubclassData and ContainedTys.
This natvis visualisation decodes and visualises those members.

Diff Detail

Event Timeline

mvhooren created this revision.May 4 2020, 8:07 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2020, 8:07 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster failed remote builds in B55638: Diff 261819!May 4 2020, 9:05 AM

Fixed trailing whitespace issue with patch.

mvhooren added a reviewer: aaron.ballman.May 14 2020, 1:12 PM

LGTM, thank you for adding some new visualizers!

This revision is now accepted and ready to land.May 15 2020, 5:17 AM

In D79331#2038320, @aaron.ballman wrote:

LGTM, thank you for adding some new visualizers!

Thanks for reviewing! I do not have commit access so if you can find the time, could you please commit this on my behalf?

I've committed on your behalf in 7063a83a7cca45a9b12a7e447c90abe681f6ebaf, thank you for the patch!

Revision Contents

Path

Size

llvm/

utils/

LLVMVisualizers/

llvm.natvis

48 lines

Diff 261871

llvm/utils/LLVMVisualizers/llvm.natvis

Show First 20 Lines • Show All 247 Lines • ▼ Show 20 Lines	<DisplayString Condition="sizeof($T1)==8">{{ big endian value = {(($T1)((unsigned char )Value.buffer) << 56)
\| ($T1)(((unsigned char )Value.buffer+7))} }}</DisplayString>		\| ($T1)(((unsigned char )Value.buffer+7))} }}</DisplayString>
<Expand>		<Expand>
<Item Name="[Raw Bytes]" Condition="sizeof($T1)==1">(unsigned char *)Value.buffer,1</Item>		<Item Name="[Raw Bytes]" Condition="sizeof($T1)==1">(unsigned char *)Value.buffer,1</Item>
<Item Name="[Raw Bytes]" Condition="sizeof($T1)==2">(unsigned char *)Value.buffer,2</Item>		<Item Name="[Raw Bytes]" Condition="sizeof($T1)==2">(unsigned char *)Value.buffer,2</Item>
<Item Name="[Raw Bytes]" Condition="sizeof($T1)==4">(unsigned char *)Value.buffer,4</Item>		<Item Name="[Raw Bytes]" Condition="sizeof($T1)==4">(unsigned char *)Value.buffer,4</Item>
<Item Name="[Raw Bytes]" Condition="sizeof($T1)==8">(unsigned char *)Value.buffer,8</Item>		<Item Name="[Raw Bytes]" Condition="sizeof($T1)==8">(unsigned char *)Value.buffer,8</Item>
</Expand>		</Expand>
</Type>		</Type>

		<!-- llvm::Type has two fields, SubclassData and ContainedTys, the meaning of which change depending on the TypeID.
		This visualiser decodes those fields based on the value of ID.
		-->
		<Type Name="llvm::Type">
		<DisplayString>{ID}</DisplayString>
		<Expand>
		<Item Name="ID">ID</Item>

		<Item Name="NumBits" Condition="ID == llvm::Type::TypeID::IntegerTyID">SubclassData</Item>

		<Item Name="ReturnType" Condition="ID == llvm::Type::TypeID::FunctionTyID">*ContainedTys</Item>
		<Synthetic Name="Arguments" Condition="ID == llvm::Type::TypeID::FunctionTyID">
		<DisplayString>{NumContainedTys - 1}</DisplayString>
		<Expand>
		<ArrayItems>
		<Size>NumContainedTys - 1</Size>
		<ValuePointer>ContainedTys + 1</ValuePointer>
		</ArrayItems>
		</Expand>
		</Synthetic>
		<Item Name="IsVarArg" Condition="ID == llvm::Type::TypeID::FunctionTyID">SubclassData == 1</Item>

		<Item Name="HasBody" Condition="ID == llvm::Type::TypeID::StructTyID">(SubclassData & llvm::StructType::SCDB_HasBody) != 0</Item>
		<Item Name="Packed" Condition="ID == llvm::Type::TypeID::StructTyID">(SubclassData & llvm::StructType::SCDB_Packed) != 0</Item>
		<Item Name="IsLiteral" Condition="ID == llvm::Type::TypeID::StructTyID">(SubclassData & llvm::StructType::SCDB_IsLiteral) != 0</Item>
		<Item Name="IsSized" Condition="ID == llvm::Type::TypeID::StructTyID">(SubclassData & llvm::StructType::SCDB_IsSized) != 0</Item>
		<Synthetic Name="Members" Condition="ID == llvm::Type::TypeID::StructTyID">
		<DisplayString>{NumContainedTys}</DisplayString>
		<Expand>
		<ArrayItems>
		<Size>NumContainedTys</Size>
		<ValuePointer>ContainedTys</ValuePointer>
		</ArrayItems>
		</Expand>
		</Synthetic>

		<Item Name="ElementType" Condition="ID == llvm::Type::TypeID::ArrayTyID \|\| ID == llvm::Type::TypeID::VectorTyID">*ContainedTys</Item>
		<Item Name="NumElements" Condition="ID == llvm::Type::TypeID::ArrayTyID">((llvm::ArrayType*)this)->NumElements</Item>

		<Item Name="AddressSpace" Condition="ID == llvm::Type::TypeID::PointerTyID">SubclassData</Item>
		<Item Name="PointeeType" Condition="ID == llvm::Type::TypeID::PointerTyID">*ContainedTys</Item>

		<Item Name="NumElements" Condition="ID == llvm::Type::TypeID::VectorTyID">((llvm::VectorType*)this)->NumElements</Item>

		<Item Name="Context">Context</Item>
		</Expand>
		</Type>
</AutoVisualizer>		</AutoVisualizer>