- User Since
- May 1 2019, 10:26 AM (28 w, 2 d)
May 14 2019
May 13 2019
Removed changes done by clang-format that are not related to this patch.
May 9 2019
Applied Clang Format to the changed files. Renamed bufferSize -> BufSize to match naming convention..
Patch was missing context in the diff, updated the patch with full context.
May 8 2019
Looking at FileOutputBuffer, I wonder why it is using MemoryBlock/allocateMappedMemory at all. It probably should be using something like a WritableMemoryBuffer instead.
I have not changed this because it is a little beyond the scope of this patch, but it might be worth investigating. Perhaps it does have a requirement somewhere that its memory should be page-aligned, but if so it is not obvious from looking at it.
Reverted changes from revisions r357058 and r351916 as discussed. Updated the InMemoryBuffer in FileOutputBuffer.cpp to track the requested buffer size.
The Size member of MemoryBlock and OwningMemoryBlock was renamed to AllocatedSize in order to provide a hint that the allocated size may be different than the requested size. I also added some comments to further clarify this point.
I have checked all the call sites of MemoryBlock::size() and as far as I can tell, FileOutputBuffer is the only location where wrong assumptions were made about the size.
May 7 2019
May 6 2019
I do not have commit access by the way.