This is an archive of the discontinued LLVM Phabricator instance.

Differential D79225

[mlir][rocdl] fix shared lib build. NFC.
ClosedPublic

Authored by whchung on Apr 30 2020, 6:37 PM.

Details

Reviewers
jpienaar
ftynse
Commits
rGd805ab7d039d: [mlir][rocdl] fix shared lib build. NFC.
Summary
  • Add missing dependency to MLIRVectorToLLVM to get shared libs built.

Diff Detail

Event Timeline

whchung created this revision.Apr 30 2020, 6:37 PM
Herald added a reviewer: ftynse. · View Herald TranscriptApr 30 2020, 6:37 PM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 13 others. · View Herald Transcript
whchung mentioned this in D79021: [mlir][nvvm][rocdl] refactor NVVM and ROCDL dialect. NFC..Apr 30 2020, 6:38 PM
Harbormaster completed remote builds in B55403: Diff 261419.Apr 30 2020, 7:00 PM
jpienaar accepted this revision.May 1 2020, 8:45 AM

Thanks

This revision is now accepted and ready to land.May 1 2020, 8:45 AM
whchung added a comment.May 1 2020, 9:56 AM

@jpienaar could you help get this patch merged? I do not yet have write access.

whchung closed this revision.May 1 2020, 10:19 AM

The patch has landed.

Revision Contents

PathSize
mlir/
lib/
Dialect/
LLVMIR/
1 line

Diff 261419

mlir/lib/Dialect/LLVMIR/CMakeLists.txt

Show First 20 Lines • Show All 77 Lines • ▼ Show 20 Linesadd_mlir_dialect_library(MLIRROCDLIR
) )
target_link_libraries(MLIRROCDLIR target_link_libraries(MLIRROCDLIR
PUBLIC PUBLIC
LLVMAsmParser LLVMAsmParser
LLVMCore LLVMCore
LLVMSupport LLVMSupport
MLIRIR MLIRIR
MLIRSideEffects MLIRSideEffects
MLIRVectorToLLVM
) )