This is an archive of the discontinued LLVM Phabricator instance.

Differential D79170

Fix minor errors
AbandonedPublic

Authored by CarolineConcatto on Apr 30 2020, 6:18 AM.

Details

Reviewers
DavidTruby
sscalpone
Summary

Signed-off-by: Caroline Concatto <caroline.concatto@arm.com>

Diff Detail

Event Timeline

CarolineConcatto created this revision.Apr 30 2020, 6:18 AM
Herald added a reviewer: DavidTruby. · View Herald TranscriptApr 30 2020, 6:18 AM
Herald added a reviewer: sscalpone. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, kristof.beyls. · View Herald Transcript
CarolineConcatto abandoned this revision.Apr 30 2020, 6:29 AM

This patch has landed here by mistake.
This is should be an update on:
https://reviews.llvm.org/D73951

Harbormaster failed remote builds in B55291: Diff 261209!Apr 30 2020, 6:47 AM

Revision Contents

PathSize
clang/
test/
Driver/
flang/
4 lines
2 lines

Diff 261209

clang/test/Driver/flang/flang-driver-2-frontend01.f90

! Check wich name of flang frontend is invoked by the driver ! Check which name of flang frontend is invoked by the driver
! The flag -fortran-fe is NOT passed by the driver. ! The flag -fortran-fe is NOT passed by the driver.
! Therefore, it uses the predefined frontend "flang". ! Therefore, it uses the predefined frontend "flang".
! Copy clang to a temporary file to be the driver name ! Copy clang to a temporary file to be the driver name
! RUN: cp %clang %t1 ! RUN: cp %clang %t1
! RUN: %t1 --driver-mode=flang -### %s 2>&1 | FileCheck --check-prefixes=ALL %s ! RUN: %t1 --driver-mode=flang -### %s 2>&1 | FileCheck --check-prefixes=ALL %s
! The invocations should begin with <test-file-name>.tmp1 -fc1. ! The invocations should begin with flang -fc1.
! ALL-LABEL: "{{[^"]*}}flang" "-fc1" ! ALL-LABEL: "{{[^"]*}}flang" "-fc1"

clang/test/Driver/flang/flang-driver-2-frontend02.f90

! Check wich name of flang frontend is invoked by the driver ! Check which name of flang frontend is invoked by the driver
! The flag -fortran-fe is passed by the driver. ! The flag -fortran-fe is passed by the driver.
! The flag has preference over the predefined frontend "flang". ! The flag has preference over the predefined frontend "flang".
! Therefore the driver invokes the FE given by the flag. ! Therefore the driver invokes the FE given by the flag.
! Copy clang to two temporary file. ! Copy clang to two temporary file.
! t1 is the driver name. t2 is the frontend name ! t1 is the driver name. t2 is the frontend name
! RUN: cp %clang %t1 ! RUN: cp %clang %t1
! RUN: cp %clang %t2 ! RUN: cp %clang %t2
! RUN: %t1 --driver-mode=flang -fortran-fe %basename_t.tmp2 -### %s 2>&1 | FileCheck --check-prefixes=ALL %s ! RUN: %t1 --driver-mode=flang -fortran-fe %basename_t.tmp2 -### %s 2>&1 | FileCheck --check-prefixes=ALL %s
! The invocations should begin with <test-file-name>.tmp2 -fc1. ! The invocations should begin with <test-file-name>.tmp2 -fc1.
! ALL-LABEL: "{{[^"]*}}flang-driver-2-frontend02.f90.tmp2" "-fc1" ! ALL-LABEL: "{{[^"]*}}flang-driver-2-frontend02.f90.tmp2" "-fc1"