Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This change is not quite ready but feel free to share any opinions/comments you might have on the changes I am making. I started with moving exp and all its friends but soon ended with a large change which even I was getting confused about. Also, I made a mistake with how LLVM libc results are compared with MPFR results. I have to fix that first before I can add more tests to this patch.
I am mostly done with everything I wanted to do in this patch but I am still leaving it without reviewers as I want to do one more pass tomorrow before I add reviewers. Like with the other math change, I want to keep the general look of the code similar to how it is in the AOR directory. So, I have not made widespread stylistic changes which would change the look and feel of the actual code. That said, as I start moving the double precision functions, it might be more appropriate to consolidate the now dispersed floating point utils into a single, more C++ like util library. I will start doing it in the following patches as I learn more about the double precision implementations.
Added reviewers now. Just pointing out again: I have not done any stylistic changes to the main code. The idea is to keep it as familiar as possible to the AOR developers when they start working with LLVM-libc.
LGTM
libc/utils/MPFRWrapper/MPFRUtils.h | ||
---|---|---|
42 | This could be enum class and we could avoid the OP_ prefix but this is fine as well. |
Classic clang-format