This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][docs] Update tutorial language around Op and Operation* and 'opaque'
ClosedPublic

Authored by stephenneuendorffer on Apr 29 2020, 4:35 PM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 4:35 PM
rriddle added inline comments.Apr 29 2020, 5:08 PM
mlir/docs/Interfaces.md
3

Maybe just it allows for representing so we don't have generic and generically right after each other?

mlir/docs/OpDefinitions.md
352

nit: allowing -> by which operations can expose?

mlir/docs/Tutorials/Toy/Ch-2.md
89

nit: Remove the double space here.

119

Same here and below, please use single space after punctuation.

282

nit: an -> a

stephenneuendorffer marked 4 inline comments as done.Apr 29 2020, 8:04 PM

Thanks for reviewing!

mlir/docs/Interfaces.md
3

I was trying to turn this into active voice in the process, but I agree it's still awkward.

mlir/docs/OpDefinitions.md
352

I think it reads better with the simpler construction. Maybe even "operation interfaces allow operations to expose..."

stephenneuendorffer marked an inline comment as done.
rriddle accepted this revision.Apr 30 2020, 4:24 PM
rriddle marked an inline comment as done.
rriddle added inline comments.
mlir/docs/OpDefinitions.md
352

SGTM

This revision is now accepted and ready to land.Apr 30 2020, 4:24 PM
This revision was automatically updated to reflect the committed changes.