Page MenuHomePhabricator

[clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names
ClosedPublic

Authored by mstorsjo on Apr 29 2020, 12:26 PM.

Details

Summary

These are mapped in MachO::getMachOArchName already, but were missing in ToolChain::getDefaultUniversalArchName.

Having these reverse mapped here fixes weird inconsistencies like -dumpmachine showing a target triple like "aarch64-apple-darwin", while "clang -target aarch64-apple-darwin" didn't use to work (ended up mapped as unknown-apple-ios).

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 29 2020, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 12:26 PM

Adding some more Apple reviewers on this one - who can give it a look?

echristo accepted this revision.May 28 2020, 1:25 PM
echristo added a subscriber: echristo.

This seems ok to me. Thanks!

This revision is now accepted and ready to land.May 28 2020, 1:25 PM
This revision was automatically updated to reflect the committed changes.