This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Correct the AfterControlStatement configuration option output style
ClosedPublic

Authored by duncan-llvm on Apr 28 2020, 9:53 AM.

Details

Summary

Due to the order in which the enum cases were defined the old options which were retained for backwards compatibility were being preferred over the new options when printing with the --dump-config option.

I wasn't sure where this stood in regard to tests - I couldn't find anything testing the enum/string conversions in this direction, so if I've missed something please point me in the right direction and I'll add something.

Diff Detail

Event Timeline

duncan-llvm created this revision.Apr 28 2020, 9:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 9:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
duncan-llvm edited the summary of this revision. (Show Details)Apr 28 2020, 10:06 AM
duncan-llvm added a reviewer: MyDeveloperDay.
duncan-llvm added a project: Restricted Project.
MyDeveloperDay accepted this revision.Apr 28 2020, 10:29 AM

This LGTM, yeah not sure about how this can be tested.

This revision is now accepted and ready to land.Apr 28 2020, 10:29 AM
duncan-llvm added a comment.EditedApr 28 2020, 10:50 AM

Based on the New Contributors section I understand I should be asking someone to commit this (and D79022) on my behalf. @MyDeveloperDay would you be able to do that for me or suggest someone else I can ask?

This revision was automatically updated to reflect the committed changes.