This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Remove unused FP reduction intrinsic definitions
ClosedPublic

Authored by c-rhodes on Apr 28 2020, 7:59 AM.

Details

Summary

FP reductions no longer use these intrinsics since D78723.

Diff Detail

Event Timeline

c-rhodes created this revision.Apr 28 2020, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 7:59 AM
sdesmalen accepted this revision.Apr 28 2020, 1:45 PM

LGTM

Can you add D78723 as a parent revision?

This revision is now accepted and ready to land.Apr 28 2020, 1:45 PM

I was thinking more along the lines of "land the entire IntrinsicsAArch64.td separately", not just deleting the dead intrinsic patterns. Maybe there's something I'm missing?

c-rhodes added a comment.EditedApr 29 2020, 3:13 AM

I was thinking more along the lines of "land the entire IntrinsicsAArch64.td separately", not just deleting the dead intrinsic patterns. Maybe there's something I'm missing?

I thought you might have meant that, sorry I should have clarified. To be honest I'm struggling to find a reason for committing the IntrinsicsAArch64.td changes separately, am I missing something?

c-rhodes updated this revision to Diff 260893.Apr 29 2020, 5:48 AM

Changes:
Moved the remaining IntrinsicsAArch64.td changes from D78723 to this patch.

efriedma accepted this revision.Apr 29 2020, 11:28 AM

LGTM

It makes review harder when I have to read a patch and spend extra time to figure out whether something that looks like an NFC change at first glance is actually supposed to be one.

LGTM

It makes review harder when I have to read a patch and spend extra time to figure out whether something that looks like an NFC change at first glance is actually supposed to be one.

No worries, thanks for reviewing!

This revision was automatically updated to reflect the committed changes.