Page MenuHomePhabricator

[clang-tidy] NFC: Cleanup Python scripts
ClosedPublic

Authored by kbobyrev on Apr 28 2020, 1:23 AM.

Details

Summary

Silence few PEP8 warnings.

Diff Detail

Event Timeline

kbobyrev created this revision.Apr 28 2020, 1:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 1:23 AM
hokein accepted this revision.Apr 28 2020, 1:49 AM

thanks for cleaning up.

clang-tools-extra/clang-tidy/add_new_check.py
1

we should keep using python I think.

This revision is now accepted and ready to land.Apr 28 2020, 1:49 AM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.EditedApr 28 2020, 6:39 AM

It would be great to also run Flake8 and PyLint.

kbobyrev updated this revision to Diff 260627.Apr 28 2020, 7:02 AM
kbobyrev marked 2 inline comments as done.

Remove python3 from shebang.

It would be great to also run Flake9 and PyLint.

Those were actually from pylint. That's a good idea, but I didn't fix all the warnings there and while I might get back to this in the future I don't think it's in the scope of this patch as this is a pretty trivial NFC cleanup.

clang-tools-extra/clang-tidy/add_new_check.py
1

Oops, a leftover from testing, thanks for noticing!

It would be great to also run Flake9 and PyLint.

Those were actually from pylint. That's a good idea, but I didn't fix all the warnings there and while I might get back to this in the future I don't think it's in the scope of this patch as this is a pretty trivial NFC cleanup.

If number of PyLint warnings (excluding identifiers naming) is not too big, it may make sense to clean-up in one commit.

This revision was automatically updated to reflect the committed changes.