This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Disable test for extension that's unsupportable in C++20
ClosedPublic

Authored by CaseyCarter on Apr 27 2020, 9:49 AM.

Details

Summary

Defining the nested types reference and iterator_concept of reverse_iterator<I> necessarily requires I to be complete in C++20. These tests that verify that std::map<int, X>::reverse_iterator can be instantiated when X is incomplete are going to have a bad time.

Diff Detail

Event Timeline

CaseyCarter created this revision.Apr 27 2020, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2020, 9:49 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Apr 27 2020, 10:13 AM

Could you add a short comment explaining the #if?

This revision now requires changes to proceed.Apr 27 2020, 10:13 AM

Review comments.

ldionne accepted this revision.Apr 27 2020, 12:48 PM
This revision is now accepted and ready to land.Apr 27 2020, 12:48 PM
This revision was automatically updated to reflect the committed changes.