This is an archive of the discontinued LLVM Phabricator instance.

[mlir][VectorOps] Extend VectorTransfer lowering to n-D memref with minor identity map
ClosedPublic

Authored by nicolasvasilache on Apr 27 2020, 6:40 AM.

Details

Summary

This revision extends the lowering of vector transfers to work with n-D memref and 1-D vector where the permutation map is an identity on the most minor dimensions (1 for now).

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2020, 6:40 AM
ftynse accepted this revision.Apr 27 2020, 6:50 AM
ftynse added inline comments.
mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
862

Nit: I don't remember if the transfer_op verifier checks for the list of indices being non-empty

This revision is now accepted and ready to land.Apr 27 2020, 6:50 AM
nicolasvasilache marked an inline comment as done.

Address review comment.

This revision was automatically updated to reflect the committed changes.