This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] [NFC] Make argv0 const
ClosedPublic

Authored by abrachet on Apr 24 2020, 4:53 PM.

Details

Summary

argv0 was never being modified. No changes made except to the type.

Diff Detail

Event Timeline

abrachet created this revision.Apr 24 2020, 4:53 PM
RKSimon accepted this revision.Apr 25 2020, 6:17 AM

LGTM - please improve the commit message to explain that argv0 is only ever used forwarded to methods that use it as a const char*

This revision is now accepted and ready to land.Apr 25 2020, 6:17 AM
abrachet edited the summary of this revision. (Show Details)Apr 25 2020, 1:36 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2020, 1:48 PM